Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: tools/telemetry/telemetry/page_runner.py

Issue 11753023: [telemetry] Clean up image decoding benchmark (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: helps if i upload a working patch Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page_runner.py
diff --git a/tools/telemetry/telemetry/page_runner.py b/tools/telemetry/telemetry/page_runner.py
index ace1ecd95772159a0e842f15a91eda3b1f01e5f9..09508b7f06020f88d5d3fa1793e2c63b5686dc8a 100644
--- a/tools/telemetry/telemetry/page_runner.py
+++ b/tools/telemetry/telemetry/page_runner.py
@@ -155,7 +155,7 @@ http://goto/read-src-internal, or create a new archive using record_wpr.
page_state = PageState()
try:
- did_prepare = self._PreparePage(page, tab, page_state, results)
+ did_prepare = self._PreparePage(page, tab, page_state, test, results)
except util.TimeoutException, ex:
logging.warning('Timed out waiting for reply on %s. This is unusual.',
page.url)
@@ -245,7 +245,7 @@ http://goto/read-src-internal, or create a new archive using record_wpr.
trace_file.write(trace)
logging.info('Trace saved.')
- def _PreparePage(self, page, tab, page_state, results):
+ def _PreparePage(self, page, tab, page_state, test, results):
parsed_url = urlparse.urlparse(page.url)
if parsed_url[0] == 'file':
dirname, filename = page.url_base_dir_and_file
@@ -264,13 +264,16 @@ http://goto/read-src-internal, or create a new archive using record_wpr.
results.AddFailure(page, msg, "")
return False
+ test.WillNavigateToPage(page, tab)
tab.page.Navigate(target_side_url)
+ test.DidNavigateToPage(page, tab)
# Wait for unpredictable redirects.
if page.wait_time_after_navigate:
time.sleep(page.wait_time_after_navigate)
page.WaitToLoad(tab, 60)
tab.WaitForDocumentReadyStateToBeInteractiveOrBetter()
+
return True
def _CleanUpPage(self, page, tab, page_state): # pylint: disable=R0201

Powered by Google App Engine
This is Rietveld 408576698