Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 11753018: Remove ScheduleAllView class from wrench_menu.cc (Closed)

Created:
7 years, 11 months ago by Evan Stade
Modified:
7 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Remove ScheduleAllView class from wrench_menu.cc Now that it is only used in one place, this class needlessly increases inheritance complexity BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175484

Patch Set 1 #

Total comments: 1

Patch Set 2 : size() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -19 lines) Patch
M chrome/browser/ui/views/wrench_menu.cc View 1 2 chunks +11 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Evan Stade
tangential question, Scott: I noticed this while looking into adding button items to a different ...
7 years, 11 months ago (2013-01-04 00:30:41 UTC) #1
tfarina
https://codereview.chromium.org/11753018/diff/1/chrome/browser/ui/views/wrench_menu.cc File chrome/browser/ui/views/wrench_menu.cc (right): https://codereview.chromium.org/11753018/diff/1/chrome/browser/ui/views/wrench_menu.cc#newcode328 chrome/browser/ui/views/wrench_menu.cc:328: View::SchedulePaintInRect(gfx::Rect(0, 0, width(), height())); nit: gfx::Rect(size())
7 years, 11 months ago (2013-01-04 19:15:34 UTC) #2
sky
LGTM Elliot added support for buttons in the menu model after this code was added. ...
7 years, 11 months ago (2013-01-07 16:28:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/11753018/13001
7 years, 11 months ago (2013-01-07 20:36:22 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) interactive_ui_tests
7 years, 11 months ago (2013-01-07 22:47:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/11753018/13001
7 years, 11 months ago (2013-01-08 02:07:29 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 03:20:59 UTC) #7
Message was sent while issue was closed.
Change committed as 175484

Powered by Google App Engine
This is Rietveld 408576698