Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 11753017: Fix onKeyAdded check causing flakiness in the tests. (Closed)

Created:
7 years, 11 months ago by shadi
Modified:
7 years, 11 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix onKeyAdded check causing flakiness in the tests, and enabling relevant disabled test. BUG=168252 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175113

Patch Set 1 #

Total comments: 2

Patch Set 2 : apply suggestion #

Patch Set 3 : Enabling disabled tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M content/browser/encrypted_media_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/media/encrypted_media_player.html View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
shadi
PTAL
7 years, 11 months ago (2013-01-03 22:58:30 UTC) #1
ddorwin
lgtm % suggestion https://codereview.chromium.org/11753017/diff/1/content/test/data/media/encrypted_media_player.html File content/test/data/media/encrypted_media_player.html (right): https://codereview.chromium.org/11753017/diff/1/content/test/data/media/encrypted_media_player.html#newcode15 content/test/data/media/encrypted_media_player.html:15: // webkitkeyadded happens right before playback, ...
7 years, 11 months ago (2013-01-03 23:29:55 UTC) #2
shadi
Enabling the disabled test as well. PTAL again. https://codereview.chromium.org/11753017/diff/1/content/test/data/media/encrypted_media_player.html File content/test/data/media/encrypted_media_player.html (right): https://codereview.chromium.org/11753017/diff/1/content/test/data/media/encrypted_media_player.html#newcode15 content/test/data/media/encrypted_media_player.html:15: // ...
7 years, 11 months ago (2013-01-04 00:09:19 UTC) #3
ddorwin
lgtm Thanks!
7 years, 11 months ago (2013-01-04 00:11:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/11753017/4002
7 years, 11 months ago (2013-01-04 00:14:24 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
7 years, 11 months ago (2013-01-04 03:57:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/11753017/4002
7 years, 11 months ago (2013-01-04 03:59:43 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 06:54:41 UTC) #8
Message was sent while issue was closed.
Change committed as 175113

Powered by Google App Engine
This is Rietveld 408576698