Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 11753015: Merge 138717 (Closed)

Created:
7 years, 11 months ago by leviw_travelin_and_unemployed
Modified:
7 years, 11 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 138717 > Fix incorrect assumption about in-flow descendants of inlines in touch event rect tracking > https://bugs.webkit.org/show_bug.cgi?id=105970 > > Reviewed by Simon Fraser. > > Source/WebCore: > > Correcting the touch event target rect accumulation code to no longer incorrectly assume that > non-block renderers held only normal-flow children. The updated code will always walk the > complete renderer sub-tree, but only do the work of calculating the absolute rect when the > child won't necessarily fall inside its parent (floating, positioned, or transformed). > > Tests: platform/chromium/fast/events/touch/compositor-touch-hit-rects.html updated to catch bug. > > * page/scrolling/ScrollingCoordinator.cpp: > (WebCore::accumulateRendererTouchEventTargetRects): Walk all renderer sub-trees. Also keeping > track of the last added parent container rect to avoid adding redundant rectangles. > (WebCore::accumulateDocumentEventTargetRects): Avoiding adding empty rects. > > LayoutTests: > > * platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Updating expectations > * platform/chromium/fast/events/touch/compositor-touch-hit-rects.html: Updating test to check previously failing case where > an inline with a touch handler contains a non-normal-flow child. Also, fixing the test since it was incorrectly duplicated. > * platform/chromium/TestExpectations: > TBR=leviw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -158 lines) Patch
M LayoutTests/platform/chromium-win/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt View 1 chunk +10 lines, -40 lines 0 comments Download
M LayoutTests/platform/chromium/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/chromium/fast/events/touch/compositor-touch-hit-rects.html View 2 chunks +20 lines, -109 lines 0 comments Download
M Source/WebCore/page/scrolling/ScrollingCoordinator.cpp View 2 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
leviw_travelin_and_unemployed
7 years, 11 months ago (2013-01-03 22:04:01 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698