DescriptionMerge 138717
> Fix incorrect assumption about in-flow descendants of inlines in touch event rect tracking
> https://bugs.webkit.org/show_bug.cgi?id=105970
>
> Reviewed by Simon Fraser.
>
> Source/WebCore:
>
> Correcting the touch event target rect accumulation code to no longer incorrectly assume that
> non-block renderers held only normal-flow children. The updated code will always walk the
> complete renderer sub-tree, but only do the work of calculating the absolute rect when the
> child won't necessarily fall inside its parent (floating, positioned, or transformed).
>
> Tests: platform/chromium/fast/events/touch/compositor-touch-hit-rects.html updated to catch bug.
>
> * page/scrolling/ScrollingCoordinator.cpp:
> (WebCore::accumulateRendererTouchEventTargetRects): Walk all renderer sub-trees. Also keeping
> track of the last added parent container rect to avoid adding redundant rectangles.
> (WebCore::accumulateDocumentEventTargetRects): Avoiding adding empty rects.
>
> LayoutTests:
>
> * platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Updating expectations
> * platform/chromium/fast/events/touch/compositor-touch-hit-rects.html: Updating test to check previously failing case where
> an inline with a touch handler contains a non-normal-flow child. Also, fixing the test since it was incorrectly duplicated.
> * platform/chromium/TestExpectations:
>
TBR=leviw@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138739
Patch Set 1 #
Messages
Total messages: 1 (0 generated)
|