Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1175253004: initialize font metrics for pdf (found by valgrind) (Closed)

Created:
5 years, 6 months ago by caryclark
Modified:
5 years, 6 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix cast #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/fonts/SkTestScalerContext.cpp View 1 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175253004/1
5 years, 6 months ago (2015-06-11 13:20:53 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/1484)
5 years, 6 months ago (2015-06-11 13:24:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175253004/20001
5 years, 6 months ago (2015-06-11 13:39:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/0edd96538e41a43c18e955726d5a10117c1f817e
5 years, 6 months ago (2015-06-11 13:46:26 UTC) #7
hal.canary
5 years, 6 months ago (2015-06-11 15:55:44 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/1175253004/diff/20001/src/fonts/SkTestScalerC...
File src/fonts/SkTestScalerContext.cpp (right):

https://codereview.chromium.org/1175253004/diff/20001/src/fonts/SkTestScalerC...
src/fonts/SkTestScalerContext.cpp:153: info->fLastGlyphID =
SkToU16(onCountGlyphs() - 1);
info->fLastGlyphID gets set twice.

Powered by Google App Engine
This is Rietveld 408576698