Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1175253002: DevTools: move filter bar into the style toolbar (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
Reviewers:
dgozman, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: move filter bar into the style toolbar BUG=499178 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196938

Patch Set 1 #

Total comments: 12

Patch Set 2 : review comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -109 lines) Patch
M Source/devtools/front_end/components/inspectorViewTabbedPane.css View 1 2 chunks +11 lines, -11 lines 0 comments Download
M Source/devtools/front_end/elements/ComputedStyleWidget.js View 1 3 chunks +26 lines, -29 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 4 chunks +16 lines, -35 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 3 chunks +10 lines, -14 lines 0 comments Download
M Source/devtools/front_end/elements/computedStyleSidebarPane.css View 1 chunk +1 line, -4 lines 0 comments Download
M Source/devtools/front_end/elements/elementsPanel.css View 1 5 chunks +16 lines, -15 lines 0 comments Download
M Source/devtools/front_end/sidebarPane.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
pfeldman
4 years, 10 months ago (2015-06-11 07:53:31 UTC) #2
dgozman
https://codereview.chromium.org/1175253002/diff/1/Source/devtools/front_end/elements/ComputedStyleWidget.js File Source/devtools/front_end/elements/ComputedStyleWidget.js (right): https://codereview.chromium.org/1175253002/diff/1/Source/devtools/front_end/elements/ComputedStyleWidget.js#newcode50 Source/devtools/front_end/elements/ComputedStyleWidget.js:50: var hbox = new WebInspector.HBox(); Just create a div ...
4 years, 10 months ago (2015-06-11 08:39:31 UTC) #3
pfeldman
https://codereview.chromium.org/1175253002/diff/1/Source/devtools/front_end/elements/ComputedStyleWidget.js File Source/devtools/front_end/elements/ComputedStyleWidget.js (right): https://codereview.chromium.org/1175253002/diff/1/Source/devtools/front_end/elements/ComputedStyleWidget.js#newcode50 Source/devtools/front_end/elements/ComputedStyleWidget.js:50: var hbox = new WebInspector.HBox(); On 2015/06/11 08:39:31, dgozman ...
4 years, 10 months ago (2015-06-11 09:56:03 UTC) #4
dgozman
lgtm
4 years, 10 months ago (2015-06-11 10:13:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175253002/20001
4 years, 10 months ago (2015-06-11 10:14:48 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-11 11:37:20 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196938

Powered by Google App Engine
This is Rietveld 408576698