Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1175243004: add one control code to toy fonts (Closed)

Created:
5 years, 6 months ago by caryclark
Modified:
5 years, 5 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

PDF expects fonts to map glyph ID 0 to the missing character. Add a mapping of glyph ID 0 to the toy font to allow for this. TBR=bungeman@google.com Committed: https://skia.googlesource.com/skia/+/6d0d6cbb3e5767510550186178b83e98c64394e5

Patch Set 1 #

Patch Set 2 : add only one control code #

Patch Set 3 : add space back #

Patch Set 4 : fix comments #

Patch Set 5 : make path-reverse gm portable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -34 lines) Patch
M gm/pathreverse.cpp View 1 2 3 4 4 chunks +38 lines, -34 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175243004/60001
5 years, 6 months ago (2015-06-11 16:35:35 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 16:40:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6d0d6cbb3e5767510550186178b83e98c64394e5

Powered by Google App Engine
This is Rietveld 408576698