Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Unified Diff: Source/web/WebSharedWorkerImpl.cpp

Issue 1175233004: WorkerThread: drop unnecessary interfaces to simplify (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: review #5 Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebEmbeddedWorkerImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebSharedWorkerImpl.cpp
diff --git a/Source/web/WebSharedWorkerImpl.cpp b/Source/web/WebSharedWorkerImpl.cpp
index 1a18be73018955ef138761cb20f94a73477a47f6..df9c5ad7a277300a7f7f05c02dc52ec6e6a82c76 100644
--- a/Source/web/WebSharedWorkerImpl.cpp
+++ b/Source/web/WebSharedWorkerImpl.cpp
@@ -77,6 +77,8 @@
namespace blink {
+// TODO(toyoshim): Share implementation with WebEmbeddedWorkerImpl as much as
+// possible.
// A thin wrapper for one-off script loading.
class WebSharedWorkerImpl::Loader : public WorkerScriptLoaderClient {
public:
@@ -183,6 +185,7 @@ WebSharedWorkerImpl::~WebSharedWorkerImpl()
m_loaderProxy->detachProvider(this);
}
+// TODO(toyoshim): Rename to terminateWorkerThread().
void WebSharedWorkerImpl::stopWorkerThread()
{
if (m_askedToTerminate)
@@ -197,7 +200,7 @@ void WebSharedWorkerImpl::stopWorkerThread()
return;
}
if (m_workerThread)
- m_workerThread->stop();
+ m_workerThread->terminate();
m_workerInspectorProxy->workerThreadTerminated();
}
« no previous file with comments | « Source/web/WebEmbeddedWorkerImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698