WorkerThread: drop unnecessary interfaces to simplify

WorkerThread: drop unnecessary interfaces to simplify

- start() and stop() were changed to virtual methods at r179117, but
  there are no inheritances. Changed to non-virtual again.

- Rename stop* to terminate* to be consistent.

- drop terminationEvent() since there are no external callers.

- Add TODOs for more cleanups.

BUG=487050
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196945

[Takashi Toyoshima, 2015-06-11 07:48:12]

toyoshim@chromium.org changed reviewers:
+ kinuko@chromium.org

[Takashi Toyoshima, 2015-06-11 07:49:15]

kinuko: PTAL.

[Takashi Toyoshima, 2015-06-11 08:01:23]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-11 08:02:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175233004/20001

[kinuko, 2015-06-11 08:42:33]

lgtm mod one nit (and one comment)

https://codereview.chromium.org/1175233004/diff/20001/Source/core/workers/Wor...
File Source/core/workers/WorkerThread.h (right):

https://codereview.chromium.org/1175233004/diff/20001/Source/core/workers/Wor...
Source/core/workers/WorkerThread.h:141: virtual void didStartRunLoop();
nit: It's subjective but I think I'd like to keep this next to didStopRunLoop,
it'd make better sense when they're paired imo.

https://codereview.chromium.org/1175233004/diff/20001/Source/web/WebSharedWor...
File Source/web/WebSharedWorkerImpl.cpp (right):

https://codereview.chromium.org/1175233004/diff/20001/Source/web/WebSharedWor...
Source/web/WebSharedWorkerImpl.cpp:186: void
WebSharedWorkerImpl::stopWorkerThread()
No need to do it in this CL but it might be better to (eventually) rename this
method too. (Btw this class and WebEmbeddedWorkerImpl share a lot but with
slight modifications, there'd be probably some code they can share)

[commit-bot: I haz the power, 2015-06-11 09:07:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 09:07:18]

Dry run: This issue passed the CQ dry run.

[Takashi Toyoshima, 2015-06-11 11:25:59]

Thanks

https://codereview.chromium.org/1175233004/diff/20001/Source/core/workers/Wor...
File Source/core/workers/WorkerThread.h (right):

https://codereview.chromium.org/1175233004/diff/20001/Source/core/workers/Wor...
Source/core/workers/WorkerThread.h:141: virtual void didStartRunLoop();
Sounds reasonable. If we could stop calling didStopRunLoop() from
WorkerScriptController, it would be great. It looks a workaround to avoid an old
security issue, but for now I'm not sure we can remove it after cleaning up the
thread termination steps.

Anyway, I'll revert this part in this change.

https://codereview.chromium.org/1175233004/diff/20001/Source/web/WebSharedWor...
File Source/web/WebSharedWorkerImpl.cpp (right):

https://codereview.chromium.org/1175233004/diff/20001/Source/web/WebSharedWor...
Source/web/WebSharedWorkerImpl.cpp:186: void
WebSharedWorkerImpl::stopWorkerThread()
Add TODOs for both.

[Takashi Toyoshima, 2015-06-11 11:26:24]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2015-06-11 11:26:24]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/1175233004/#ps40001
(title: "review #5")

[Takashi Toyoshima, 2015-06-11 11:26:28]

The CQ bit was unchecked by toyoshim@chromium.org

[Takashi Toyoshima, 2015-06-11 11:27:59]

CL descriptions were slightly modified to be matched with the updated patch.

[Takashi Toyoshima, 2015-06-11 11:28:03]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2015-06-11 11:28:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175233004/40001

[commit-bot: I haz the power, 2015-06-11 11:34:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 11:34:48]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

[Takashi Toyoshima, 2015-06-11 11:52:46]

toyoshim@chromium.org changed reviewers:
+ tkent@chromium.org

[Takashi Toyoshima, 2015-06-11 11:53:22]

+tkent for Source/web
PTAL.

[tkent, 2015-06-11 12:21:32]

The CQ bit was checked by tkent@chromium.org

[tkent, 2015-06-11 12:21:33]

lgtm

[commit-bot: I haz the power, 2015-06-11 12:21:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175233004/40001

[commit-bot: I haz the power, 2015-06-11 12:43:05]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196945