Make it possible to modify background HTML parser token limits.

Source/core/html/parser/HTMLDocumentParser.cpp

 /*
  * Copyright (C) 2010 Google, Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 765 matching lines @@
             loader->attachThreadedDataReceiver(ParserDataReceiver::create(m_backgroundParser, document()->contextDocument().get()));
     }
 
     OwnPtr<BackgroundHTMLParser::Configuration> config = adoptPtr(new BackgroundHTMLParser::Configuration);
     config->options = m_options;
     config->parser = m_weakFactory.createWeakPtr();
     config->xssAuditor = adoptPtr(new XSSAuditor);
     config->xssAuditor->init(document(), &m_xssAuditorDelegate);
     config->preloadScanner = adoptPtr(new TokenPreloadScanner(document()->url().copy(), CachedDocumentParameters::create(document())));
     config->decoder = takeDecoder();
+    if (document()->settings()) {

[Nate Chapin, 2015/06/11 18:48:23]

I think Document::settings should only be null here for XHR document responses.
Any thoughts on whether it's a bad thing to use the defaults for those kinds of
document?

[Bryan McQuade, 2015/06/12 14:12:59]

Ah, interesting. I think varying these constants are less important for XHR'd
documents. The primary motivation for being able to change these values is to be
able to control how much we look ahead of the parser with the preload scanner,
which isn't relevant for XHR'd documents - IIUC XHR'd docs don't actually
trigger fetches for things like <scripts> until they are inserted into an HTML
document(let me know if that's not right). So I think this is ok. Let me know if
you disagree though.

[Nate Chapin, 2015/06/12 17:02:59]

I'm not terribly familiar with our XHR document logic, but in general I agree
that documents without a frame() shouldn't be able to request subresources.

+        if (document()->settings()->backgroundHtmlParserOutstandingTokenLimit() > 0)
+            config->outstandingTokenLimit = document()->settings()->backgroundHtmlParserOutstandingTokenLimit();
+        if (document()->settings()->backgroundHtmlParserPendingTokenLimit() > 0)

[Nate Chapin, 2015/06/11 18:48:23]

if these become unsigned, drop the " > 0"

[Bryan McQuade, 2015/06/12 14:12:59]

Done.

+            config->pendingTokenLimit = document()->settings()->backgroundHtmlParserPendingTokenLimit();
+    }
 
     ASSERT(config->xssAuditor->isSafeToSendToAnotherThread());
     ASSERT(config->preloadScanner->isSafeToSendToAnotherThread());
     HTMLParserThread::shared()->postTask(threadSafeBind(&BackgroundHTMLParser::start, reference.release(), config.release(),
         AllowCrossThreadAccess(Platform::current()->currentThread()->scheduler())));
 }
 
 void HTMLDocumentParser::stopBackgroundParser()
 {
     ASSERT(shouldUseThreading());
@@ skipping 312 matching lines @@
 void HTMLDocumentParser::setDecoder(PassOwnPtr<TextResourceDecoder> decoder)
 {
     ASSERT(decoder);
     DecodedDataDocumentParser::setDecoder(decoder);
 
     if (m_haveBackgroundParser)
         HTMLParserThread::shared()->postTask(threadSafeBind(&BackgroundHTMLParser::setDecoder, AllowCrossThreadAccess(m_backgroundParser), takeDecoder()));
 }
 
 }