Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1175133002: Revert of Android FRE: A New Deal (Closed)

Created:
5 years, 6 months ago by aruslan
Modified:
5 years, 6 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, maxbogue, Ted C
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android FRE: A New Deal (patchset #2 id:20001 of https://codereview.chromium.org/1171833004/) Reason for revert: People changed their minds. See http://crbug.com/450423#c13 Original issue's description: > Android FRE: A New Deal > > Simplified as follows: > - If '--disable-fre' -- skip temporarily > - If a device hasn't been provisioned yet -- skip temporarily > - If FRE has already been completed -- great > - Otherwise, we start the FRE activity to see what to show. > > Note that it doesn't matter how exactly Chrome was launched > (say, via the shortcut or via a VIEW intent), it always shows > the full FRE unless it's a test or the Setup Wizard environment. > > BUG=450423 > > Committed: https://crrev.com/7a009eef84baa72003378bf1e4135e850ca1d708 > Cr-Commit-Position: refs/heads/master@{#333612} TBR=aurimas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=450423 Committed: https://crrev.com/b52d2165060e5ff686d4436b9f76fb2b3ce98837 Cr-Commit-Position: refs/heads/master@{#333835}

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
aruslan
Created Revert of Android FRE: A New Deal
5 years, 6 months ago (2015-06-10 23:08:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175133002/1
5 years, 6 months ago (2015-06-10 23:10:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 23:13:04 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 23:14:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b52d2165060e5ff686d4436b9f76fb2b3ce98837
Cr-Commit-Position: refs/heads/master@{#333835}

Powered by Google App Engine
This is Rietveld 408576698