Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 117513006: Remove experimental code fro grouping notifications from the same source. (Closed)

Created:
6 years, 11 months ago by Dmitry Titov
Modified:
6 years, 11 months ago
Reviewers:
Lei Zhang, dewittj
CC:
chromium-reviews
Visibility:
Public.

Description

Remove experimental code fro grouping notifications from the same source. BUG=320827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242998

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -522 lines) Patch
M ui/message_center/message_center.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/message_center/views/group_view.h View 1 chunk +0 lines, -73 lines 0 comments Download
D ui/message_center/views/group_view.cc View 1 chunk +0 lines, -253 lines 0 comments Download
M ui/message_center/views/message_center_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/message_center/views/message_center_view.h View 4 chunks +0 lines, -15 lines 0 comments Download
M ui/message_center/views/message_center_view.cc View 9 chunks +7 lines, -112 lines 0 comments Download
M ui/message_center/views/message_center_view_unittest.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M ui/message_center/views/message_popup_collection.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/message_center/views/message_popup_collection.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M ui/message_center/views/toast_contents_view.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/message_center/views/toast_contents_view.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dmitry Titov
6 years, 11 months ago (2014-01-03 23:16:26 UTC) #1
dewittj
lgtm but sad to see it go so soon...
6 years, 11 months ago (2014-01-03 23:18:10 UTC) #2
Dmitry Titov
We can always revert it :-) later.
6 years, 11 months ago (2014-01-03 23:32:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dimich@chromium.org/117513006/1
6 years, 11 months ago (2014-01-03 23:33:13 UTC) #4
commit-bot: I haz the power
Change committed as 242998
6 years, 11 months ago (2014-01-04 03:48:35 UTC) #5
Lei Zhang
6 years, 11 months ago (2014-01-10 22:35:30 UTC) #6
Message was sent while issue was closed.
BTW, you forgot to remove IDS_MESSAGE_CENTER_MORE_FROM

Powered by Google App Engine
This is Rietveld 408576698