[GCM] Add TTL support

google_apis/gcm/base/mcs_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/gcm/base/mcs_util.h"
 
 #include "base/format_macros.h"
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
+#include "base/time/clock.h"
+#include "base/time/time.h"
 
 namespace gcm {
 
 namespace {
 
 // Type names corresponding to MCSProtoTags. Useful for identifying what type
 // of MCS protobuf is contained within a google::protobuf::MessageLite object.
 // WARNING: must match the order in MCSProtoTag.
 const char* kProtoNames[] = {
   "mcs_proto.HeartbeatPing",
@@ skipping 181 matching lines @@
   }
   // Not all message types have last stream ids. Just return 0.
   return 0;
 }
 
 void SetLastStreamIdReceived(uint32 val,
                              google::protobuf::MessageLite* protobuf) {
   if (protobuf->GetTypeName() == kProtoNames[kIqStanzaTag]) {
     reinterpret_cast<mcs_proto::IqStanza*>(protobuf)->
         set_last_stream_id_received(val);
-     return;
+      return;

[fgorski, 2013/12/28 01:15:08]

should be indented 2 to the left (under reinterpret)
applies below as well.

[Nicolas Zea, 2013/12/30 21:46:19]

Done.

   } else if (protobuf->GetTypeName() == kProtoNames[kHeartbeatPingTag]) {
     reinterpret_cast<mcs_proto::HeartbeatPing*>(protobuf)->
         set_last_stream_id_received(val);
-     return;
+      return;
   } else if (protobuf->GetTypeName() == kProtoNames[kHeartbeatAckTag]) {
     reinterpret_cast<mcs_proto::HeartbeatAck*>(protobuf)->
         set_last_stream_id_received(val);
-     return;
+      return;
   } else if (protobuf->GetTypeName() == kProtoNames[kDataMessageStanzaTag]) {
     reinterpret_cast<mcs_proto::DataMessageStanza*>(protobuf)->
         set_last_stream_id_received(val);
-     return;
+      return;
   } else if (protobuf->GetTypeName() == kProtoNames[kLoginResponseTag]) {
     reinterpret_cast<mcs_proto::LoginResponse*>(protobuf)->
         set_last_stream_id_received(val);
-     return;
+      return;
   }
   NOTREACHED();
 }
 
+bool HasTTLExpired(const google::protobuf::MessageLite& protobuf,
+                   base::Clock* clock) {
+  if (protobuf.GetTypeName() != kProtoNames[kDataMessageStanzaTag])
+    return false;
+  uint64 ttl =
+      reinterpret_cast<const mcs_proto::DataMessageStanza*>(&protobuf)->ttl();
+  uint64 sent =
+      reinterpret_cast<const mcs_proto::DataMessageStanza*>(&protobuf)->sent();
+  if (ttl > 0 &&

[fgorski, 2013/12/28 01:15:08]

would a single return in place of if statement work?

[Nicolas Zea, 2013/12/30 21:46:19]

Done.

+      clock->Now() >
+          base::Time::FromInternalValue(
+              (sent + ttl) * base::Time::kMicrosecondsPerSecond)) {
+    return true;
+  }
+  return false;
+}
+
+int GetTTL(const google::protobuf::MessageLite& protobuf) {
+  if (protobuf.GetTypeName() != kProtoNames[kDataMessageStanzaTag])
+    return 0;
+  return reinterpret_cast<const mcs_proto::DataMessageStanza*>(&protobuf)->

[fgorski, 2013/12/28 01:15:08]

ttl might not be set, return max in that case.

[Nicolas Zea, 2013/12/30 21:46:19]

Should we default to max, or assume that the message is not reliable? It seems a
bit safer to assume take the less expensive option.

[fgorski, 2014/01/02 18:09:27]

The API allows the user to not set the TTL and a default equal to MAX is assumed
in that case. We can compensate for that and explicitly set it on the message at
some point, but we would have to be really smart about it.
If you omit setting TTL on protobuf, MCS will assume max.
I think so should the client side code in case of missing TTL.

[Nicolas Zea, 2014/01/02 21:39:08]

Done.

+      ttl();
+}
+
 }  // namespace gcm