Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: verification/presubmit_shim.py

Issue 117513003: Removed an assert in presubmit_shim.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue
Patch Set: Removed pylint warning suppression comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # coding=utf8 2 # coding=utf8
3 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 """Runs presubmit check on the source tree. 6 """Runs presubmit check on the source tree.
7 7
8 This shims removes the checks for try jobs. 8 This shims removes the checks for try jobs.
9 """ 9 """
10 10
11 import os 11 import os
12 import sys 12 import sys
13 13
14 ROOT_DIR = os.path.dirname(os.path.abspath(__file__)) 14 ROOT_DIR = os.path.dirname(os.path.abspath(__file__))
15 sys.path.insert(0, os.path.dirname(ROOT_DIR)) 15 sys.path.insert(0, os.path.dirname(ROOT_DIR))
16 16
17 import find_depot_tools # pylint: disable=W0611 17 import find_depot_tools # pylint: disable=W0611
18 import presubmit_support 18 import presubmit_support
19 19
20 # Do not pass them through the command line. 20 # Do not pass them through the command line.
21 email = sys.stdin.readline().strip() 21 email = sys.stdin.readline().strip()
22 assert email 22 assert email
23 password = sys.stdin.readline().strip() 23 password = sys.stdin.readline().strip()
24 assert password
25 sys.stdin.close() 24 sys.stdin.close()
26 25
27 argv = sys.argv[1:] 26 argv = sys.argv[1:]
28 argv.extend(['--rietveld_email', email, '--rietveld_password', password]) 27 argv.extend(['--rietveld_email', email, '--rietveld_password', password])
29 argv.extend(['--skip_canned', 'CheckRietveldTryJobExecution']) 28 argv.extend(['--skip_canned', 'CheckRietveldTryJobExecution'])
30 argv.extend(['--skip_canned', 'CheckTreeIsOpen']) 29 argv.extend(['--skip_canned', 'CheckTreeIsOpen'])
31 argv.extend(['--skip_canned', 'CheckBuildbotPendingBuilds']) 30 argv.extend(['--skip_canned', 'CheckBuildbotPendingBuilds'])
32 31
33 sys.exit(presubmit_support.Main(argv)) 32 sys.exit(presubmit_support.Main(argv))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698