Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2096)

Unified Diff: cc/layers/picture_layer.cc

Issue 1175113010: cc: Rename visible_content_rect and content stuff on quads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename-visible-content-rect: comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/picture_layer.cc
diff --git a/cc/layers/picture_layer.cc b/cc/layers/picture_layer.cc
index 17b1499826ccca4df24672dd00f77caf48798e79..118792c8b4739a6ce466575ba151ad3f0774e3ea 100644
--- a/cc/layers/picture_layer.cc
+++ b/cc/layers/picture_layer.cc
@@ -117,10 +117,10 @@ bool PictureLayer::Update(ResourceUpdateQueue* queue) {
update_source_frame_number_ = layer_tree_host()->source_frame_number();
bool updated = Layer::Update(queue);
- gfx::Rect visible_layer_rect = visible_content_rect();
+ gfx::Rect update_rect = visible_layer_rect();
gfx::Size layer_size = paint_properties().bounds;
- if (last_updated_visible_content_rect_ == visible_content_rect() &&
+ if (last_updated_visible_layer_rect_ == update_rect &&
recording_source_->GetSize() == layer_size &&
pending_invalidation_.IsEmpty()) {
// Only early out if the visible content rect of this layer hasn't changed.
@@ -145,7 +145,7 @@ bool PictureLayer::Update(ResourceUpdateQueue* queue) {
if (layer_tree_host()->settings().record_full_layer) {
// Workaround for http://crbug.com/235910 - to retain backwards compat
// the full page content must always be provided in the picture layer.
- visible_layer_rect = gfx::Rect(layer_size);
+ update_rect = gfx::Rect(layer_size);
}
// UpdateAndExpandInvalidation will give us an invalidation that covers
@@ -154,9 +154,9 @@ bool PictureLayer::Update(ResourceUpdateQueue* queue) {
// for them.
DCHECK(client_);
updated |= recording_source_->UpdateAndExpandInvalidation(
- client_, &recording_invalidation_, layer_size, visible_layer_rect,
+ client_, &recording_invalidation_, layer_size, update_rect,
update_source_frame_number_, RecordingSource::RECORD_NORMALLY);
- last_updated_visible_content_rect_ = visible_content_rect();
+ last_updated_visible_layer_rect_ = visible_layer_rect();
if (updated) {
SetNeedsPushProperties();

Powered by Google App Engine
This is Rietveld 408576698