Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Side by Side Diff: cc/quads/shared_quad_state.cc

Issue 1175113010: cc: Rename visible_content_rect and content stuff on quads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename-visible-content-rect: comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/quads/shared_quad_state.h" 5 #include "cc/quads/shared_quad_state.h"
6 6
7 #include "base/trace_event/trace_event_argument.h" 7 #include "base/trace_event/trace_event_argument.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "cc/base/math_util.h" 9 #include "cc/base/math_util.h"
10 #include "cc/debug/traced_value.h" 10 #include "cc/debug/traced_value.h"
(...skipping 10 matching lines...) Expand all
21 SharedQuadState::~SharedQuadState() { 21 SharedQuadState::~SharedQuadState() {
22 TRACE_EVENT_OBJECT_DELETED_WITH_ID( 22 TRACE_EVENT_OBJECT_DELETED_WITH_ID(
23 TRACE_DISABLED_BY_DEFAULT("cc.debug.quads"), 23 TRACE_DISABLED_BY_DEFAULT("cc.debug.quads"),
24 "cc::SharedQuadState", this); 24 "cc::SharedQuadState", this);
25 } 25 }
26 26
27 void SharedQuadState::CopyFrom(const SharedQuadState* other) { 27 void SharedQuadState::CopyFrom(const SharedQuadState* other) {
28 *this = *other; 28 *this = *other;
29 } 29 }
30 30
31 void SharedQuadState::SetAll(const gfx::Transform& content_to_target_transform, 31 void SharedQuadState::SetAll(const gfx::Transform& quad_to_target_transform,
32 const gfx::Size& content_bounds, 32 const gfx::Size& quad_layer_bounds,
33 const gfx::Rect& visible_content_rect, 33 const gfx::Rect& visible_quad_layer_rect,
34 const gfx::Rect& clip_rect, 34 const gfx::Rect& clip_rect,
35 bool is_clipped, 35 bool is_clipped,
36 float opacity, 36 float opacity,
37 SkXfermode::Mode blend_mode, 37 SkXfermode::Mode blend_mode,
38 int sorting_context_id) { 38 int sorting_context_id) {
39 this->content_to_target_transform = content_to_target_transform; 39 this->quad_to_target_transform = quad_to_target_transform;
40 this->content_bounds = content_bounds; 40 this->quad_layer_bounds = quad_layer_bounds;
41 this->visible_content_rect = visible_content_rect; 41 this->visible_quad_layer_rect = visible_quad_layer_rect;
42 this->clip_rect = clip_rect; 42 this->clip_rect = clip_rect;
43 this->is_clipped = is_clipped; 43 this->is_clipped = is_clipped;
44 this->opacity = opacity; 44 this->opacity = opacity;
45 this->blend_mode = blend_mode; 45 this->blend_mode = blend_mode;
46 this->sorting_context_id = sorting_context_id; 46 this->sorting_context_id = sorting_context_id;
47 } 47 }
48 48
49 void SharedQuadState::AsValueInto(base::trace_event::TracedValue* value) const { 49 void SharedQuadState::AsValueInto(base::trace_event::TracedValue* value) const {
50 MathUtil::AddToTracedValue("transform", content_to_target_transform, value); 50 MathUtil::AddToTracedValue("transform", quad_to_target_transform, value);
51 MathUtil::AddToTracedValue("layer_content_bounds", content_bounds, value); 51 MathUtil::AddToTracedValue("content_bounds", quad_layer_bounds, value);
52 MathUtil::AddToTracedValue("layer_visible_content_rect", visible_content_rect, 52 MathUtil::AddToTracedValue("content_visible_rect", visible_quad_layer_rect,
enne (OOO) 2015/06/18 21:02:15 Are these used by trace viewer?
danakj 2015/06/18 21:06:34 Oops I was trying to leave these unchanged cuz ya.
53 value); 53 value);
54 54
55 value->SetBoolean("is_clipped", is_clipped); 55 value->SetBoolean("is_clipped", is_clipped);
56 56
57 MathUtil::AddToTracedValue("clip_rect", clip_rect, value); 57 MathUtil::AddToTracedValue("clip_rect", clip_rect, value);
58 58
59 value->SetDouble("opacity", opacity); 59 value->SetDouble("opacity", opacity);
60 value->SetString("blend_mode", SkXfermode::ModeName(blend_mode)); 60 value->SetString("blend_mode", SkXfermode::ModeName(blend_mode));
61 TracedValue::MakeDictIntoImplicitSnapshotWithCategory( 61 TracedValue::MakeDictIntoImplicitSnapshotWithCategory(
62 TRACE_DISABLED_BY_DEFAULT("cc.debug.quads"), 62 TRACE_DISABLED_BY_DEFAULT("cc.debug.quads"),
63 value, 63 value,
64 "cc::SharedQuadState", 64 "cc::SharedQuadState",
65 this); 65 this);
66 } 66 }
67 67
68 } // namespace cc 68 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698