Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1563)

Issue 1175113009: Don't use FrameLoader::m_provisionalItem for history state if a cross-origin (Closed)

Created:
5 years, 6 months ago by Nate Chapin
Modified:
5 years, 5 months ago
Reviewers:
dcheng
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't use FrameLoader::m_provisionalItem for history state if a cross-origin redirect happens BUG=500554 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198022

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Give receivedMainResourceRedirect the right url #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2 lines) Patch
A LayoutTests/http/tests/history/cross-origin-redirect-on-back.html View 1 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/history/cross-origin-redirect-on-back-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 2 3 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Nate Chapin
5 years, 5 months ago (2015-06-29 16:05:14 UTC) #2
dcheng
lgtm
5 years, 5 months ago (2015-06-29 20:31:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175113009/60001
5 years, 5 months ago (2015-06-29 20:51:48 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 21:48:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198022

Powered by Google App Engine
This is Rietveld 408576698