Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1175113008: [tools] Add gc-nvp-to-csv.py script. (Closed)

Created:
5 years, 6 months ago by rmcilroy
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Add gc-nvp-to-csv.py script. Adds a script for converting gc nvp output into csv files. Factors out common code in gc-nvp-trace-processor.py to gc_nvp_common.py to be shared by both scripts. Fixes a couple of issues in nvp parsing code. Committed: https://crrev.com/c136032c44d8ae7fc9bd822875769f947ae1c28d Cr-Commit-Position: refs/heads/master@{#29141}

Patch Set 1 #

Patch Set 2 : Fix headers #

Total comments: 2

Patch Set 3 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -35 lines) Patch
A tools/gc-nvp-to-csv.py View 1 1 chunk +30 lines, -0 lines 0 comments Download
M tools/gc-nvp-trace-processor.py View 4 chunks +5 lines, -35 lines 0 comments Download
A tools/gc_nvp_common.py View 1 2 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rmcilroy
Hannes: PTAL, thanks. Orion: FYI (but comments also welcome).
5 years, 6 months ago (2015-06-18 18:11:01 UTC) #2
Hannes Payer (out of office)
LGTM, with one nit https://codereview.chromium.org/1175113008/diff/20001/tools/gc_nvp_common.py File tools/gc_nvp_common.py (right): https://codereview.chromium.org/1175113008/diff/20001/tools/gc_nvp_common.py#newcode6 tools/gc_nvp_common.py:6: # Common code for parsing ...
5 years, 6 months ago (2015-06-18 20:57:57 UTC) #3
rmcilroy
https://codereview.chromium.org/1175113008/diff/20001/tools/gc_nvp_common.py File tools/gc_nvp_common.py (right): https://codereview.chromium.org/1175113008/diff/20001/tools/gc_nvp_common.py#newcode6 tools/gc_nvp_common.py:6: # Common code for parsing gc-nvp output. On 2015/06/18 ...
5 years, 6 months ago (2015-06-19 09:24:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175113008/40001
5 years, 6 months ago (2015-06-19 09:24:25 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-19 10:40:54 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 10:40:57 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c136032c44d8ae7fc9bd822875769f947ae1c28d
Cr-Commit-Position: refs/heads/master@{#29141}

Powered by Google App Engine
This is Rietveld 408576698