Devtools: Fix "unable to change the value of R/G/B/A" in color picker

Devtools: Fix "unable to change the value of R/G/B/A" in color picker

BUG=501265
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197388

[sergeyv, 2015-06-18 15:26:27]

sergeyv@chromium.org changed reviewers:
+ lushnikov@chromium.org, pfeldman@chromium.org

[lushnikov, 2015-06-18 15:36:06]

lgtm

https://codereview.chromium.org/1175113007/diff/1/Source/devtools/front_end/e...
File Source/devtools/front_end/elements/Spectrum.js (right):

https://codereview.chromium.org/1175113007/diff/1/Source/devtools/front_end/e...
Source/devtools/front_end/elements/Spectrum.js:318: var pageKeyPressed =
(event.keyIdentifier === "PageUp" || event.keyIdentifier === "PageDown");
why not a single "var whitelistedEvent = ..." ?

https://codereview.chromium.org/1175113007/diff/1/Source/devtools/front_end/e...
Source/devtools/front_end/elements/Spectrum.js:323: element.selectionStart = 0;
are these defined on HTMLInputElement only? Can we cast element to
HTMLInputElement for clarity then?

[sergeyv, 2015-06-18 16:55:37]

https://codereview.chromium.org/1175113007/diff/1/Source/devtools/front_end/e...
File Source/devtools/front_end/elements/Spectrum.js (right):

https://codereview.chromium.org/1175113007/diff/1/Source/devtools/front_end/e...
Source/devtools/front_end/elements/Spectrum.js:318: var pageKeyPressed =
(event.keyIdentifier === "PageUp" || event.keyIdentifier === "PageDown");
On 2015/06/18 15:36:06, lushnikov wrote:
> why not a single "var whitelistedEvent = ..." ?

Acknowledged.

https://codereview.chromium.org/1175113007/diff/1/Source/devtools/front_end/e...
Source/devtools/front_end/elements/Spectrum.js:323: element.selectionStart = 0;
On 2015/06/18 15:36:06, lushnikov wrote:
> are these defined on HTMLInputElement only? Can we cast element to
> HTMLInputElement for clarity then?

renamed inputElement

[sergeyv, 2015-06-18 16:55:50]

The CQ bit was checked by sergeyv@chromium.org

[sergeyv, 2015-06-18 16:55:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/1175113007/#ps20001
(title: "Rename variable")

[commit-bot: I haz the power, 2015-06-18 16:56:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175113007/20001

[commit-bot: I haz the power, 2015-06-18 18:36:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-18 18:36:53]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59550)

[sergeyv, 2015-06-18 18:42:10]

The CQ bit was checked by sergeyv@chromium.org

[commit-bot: I haz the power, 2015-06-18 18:42:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175113007/20001

[commit-bot: I haz the power, 2015-06-18 19:27:48]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197388