Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 1175113007: Devtools: Fix "unable to change the value of R/G/B/A" in color picker (Closed)

Created:
4 years, 10 months ago by sergeyv
Modified:
4 years, 10 months ago
Reviewers:
lushnikov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: Fix "unable to change the value of R/G/B/A" in color picker BUG=501265 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197388

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rename variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -27 lines) Patch
M Source/devtools/front_end/elements/Spectrum.js View 1 1 chunk +11 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ui/UIUtils.js View 2 chunks +37 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sergeyv
4 years, 10 months ago (2015-06-18 15:26:27 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/1175113007/diff/1/Source/devtools/front_end/elements/Spectrum.js File Source/devtools/front_end/elements/Spectrum.js (right): https://codereview.chromium.org/1175113007/diff/1/Source/devtools/front_end/elements/Spectrum.js#newcode318 Source/devtools/front_end/elements/Spectrum.js:318: var pageKeyPressed = (event.keyIdentifier === "PageUp" || event.keyIdentifier ...
4 years, 10 months ago (2015-06-18 15:36:06 UTC) #3
sergeyv
https://codereview.chromium.org/1175113007/diff/1/Source/devtools/front_end/elements/Spectrum.js File Source/devtools/front_end/elements/Spectrum.js (right): https://codereview.chromium.org/1175113007/diff/1/Source/devtools/front_end/elements/Spectrum.js#newcode318 Source/devtools/front_end/elements/Spectrum.js:318: var pageKeyPressed = (event.keyIdentifier === "PageUp" || event.keyIdentifier === ...
4 years, 10 months ago (2015-06-18 16:55:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175113007/20001
4 years, 10 months ago (2015-06-18 16:56:20 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59550)
4 years, 10 months ago (2015-06-18 18:36:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175113007/20001
4 years, 10 months ago (2015-06-18 18:42:39 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 19:27:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197388

Powered by Google App Engine
This is Rietveld 408576698