Issue 1175103004: Fix "git cl map-branches -vvv"

Issue 1175103004: Fix "git cl map-branches -vvv" (Closed)

Created:
5 years, 6 months ago by sdefresne

Modified:
5 years, 6 months ago

Reviewers:
Vadim Sh., iannucci, nodir

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, nodir

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

Fix "git cl map-branches -vvv" CL https://codereview.chromium.org/1172223002 changed the meaning of the third value in the tuple returned by get_cl_statuses from a color to the status of the branch and broke the formatting of output. Convert the status to the color using color_for_status helper function. BUG=499189 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295618

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	git_map_branches.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 9 (3 generated)

iannucci

On 2015/06/11 08:49:44, sdefresne wrote: > Please take a look. Ha, I just posted exactly ...

5 years, 6 months ago (2015-06-11 09:11:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175103004/1

5 years, 6 months ago (2015-06-11 09:37:05 UTC) #7

commit-bot: I haz the power

Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295618

5 years, 6 months ago (2015-06-11 09:39:42 UTC) #8

Message was sent while issue was closed.

lgtm