Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 11751002: views: Cancel menu selection on tap-cancel. (Closed)

Created:
7 years, 11 months ago by sadrul
Modified:
7 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, Ben Goodger (Google)
Visibility:
Public.

Description

views: Cancel menu selection on tap-cancel. The menu-item under the finger gets selected on tap-down. However, if the gesture ends up scrolling the menu, then the item should be unselected. BUG=161487 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175575

Patch Set 1 #

Total comments: 5

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M ui/views/controls/menu/menu_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 3 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sadrul
This depends on https://codereview.chromium.org/11740006/ https://codereview.chromium.org/11751002/diff/1/ui/views/controls/menu/menu_controller.cc File ui/views/controls/menu/menu_controller.cc (left): https://codereview.chromium.org/11751002/diff/1/ui/views/controls/menu/menu_controller.cc#oldcode746 ui/views/controls/menu/menu_controller.cc:746: // TODO(sky): convert back to ...
7 years, 11 months ago (2013-01-02 20:08:36 UTC) #1
sadrul
Redirecting to sky@
7 years, 11 months ago (2013-01-07 23:32:24 UTC) #2
sky
https://codereview.chromium.org/11751002/diff/1/ui/views/controls/menu/menu_controller.cc File ui/views/controls/menu/menu_controller.cc (right): https://codereview.chromium.org/11751002/diff/1/ui/views/controls/menu/menu_controller.cc#newcode537 ui/views/controls/menu/menu_controller.cc:537: pending_state_.item && Why the check for pending_state_.item here? https://codereview.chromium.org/11751002/diff/1/ui/views/controls/menu/menu_controller.cc#newcode542 ...
7 years, 11 months ago (2013-01-08 04:47:03 UTC) #3
sadrul
https://codereview.chromium.org/11751002/diff/1/ui/views/controls/menu/menu_controller.cc File ui/views/controls/menu/menu_controller.cc (right): https://codereview.chromium.org/11751002/diff/1/ui/views/controls/menu/menu_controller.cc#newcode537 ui/views/controls/menu/menu_controller.cc:537: pending_state_.item && On 2013/01/08 04:47:03, sky wrote: > Why ...
7 years, 11 months ago (2013-01-08 08:10:26 UTC) #4
sky
7 years, 11 months ago (2013-01-08 18:54:10 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698