views: Cancel menu selection on tap-cancel.

views: Cancel menu selection on tap-cancel.

The menu-item under the finger gets selected on tap-down. However,
if the gesture ends up scrolling the menu, then the item should be
unselected.

BUG=161487
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175575

[sadrul, 2013-01-02 20:08:36]

This depends on https://codereview.chromium.org/11740006/

https://codereview.chromium.org/11751002/diff/1/ui/views/controls/menu/menu_c...
File ui/views/controls/menu/menu_controller.cc (left):

https://codereview.chromium.org/11751002/diff/1/ui/views/controls/menu/menu_c...
ui/views/controls/menu/menu_controller.cc:746: // TODO(sky): convert back to
DCHECK when figure out 93471.
The bug is now fixed.

[sadrul, 2013-01-07 23:32:24]

Redirecting to sky@

[sky, 2013-01-08 04:47:03]

https://codereview.chromium.org/11751002/diff/1/ui/views/controls/menu/menu_c...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/11751002/diff/1/ui/views/controls/menu/menu_c...
ui/views/controls/menu/menu_controller.cc:537: pending_state_.item &&
Why the check for pending_state_.item here?

https://codereview.chromium.org/11751002/diff/1/ui/views/controls/menu/menu_c...
ui/views/controls/menu/menu_controller.cc:542:
SetSelection(part.menu->GetParentMenuItem(),
parn->menu can be NULL even if type == MENU_ITEM.

[sadrul, 2013-01-08 08:10:26]

https://codereview.chromium.org/11751002/diff/1/ui/views/controls/menu/menu_c...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/11751002/diff/1/ui/views/controls/menu/menu_c...
ui/views/controls/menu/menu_controller.cc:537: pending_state_.item &&
On 2013/01/08 04:47:03, sky wrote:
> Why the check for pending_state_.item here?

Hm. You are right. It looks like it's not necessary to check for
pending_state_.item here.

https://codereview.chromium.org/11751002/diff/1/ui/views/controls/menu/menu_c...
ui/views/controls/menu/menu_controller.cc:542:
SetSelection(part.menu->GetParentMenuItem(),
On 2013/01/08 04:47:03, sky wrote:
> parn->menu can be NULL even if type == MENU_ITEM.

Ah, I see. I have added a check for non-null part.menu before we get here.

[sky, 2013-01-08 18:54:10]

LGTM