Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1175083002: ChannelMojo: Make MOJO_RESULT_FAILED_PRECONDITION an error. (Closed)

Created:
5 years, 6 months ago by Hajime Morrita
Modified:
5 years, 6 months ago
Reviewers:
agl, viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChannelMojo: Make MOJO_RESULT_FAILED_PRECONDITION an error. ChannelMojo used to ignore this error, which signals a closed peer, and silently closes the channel. This CL let it resuls an error because the old behavior seems incompatible to traditional IPC::Channel implementations. To sheriffs: This is likely to be what you are looking for if you're chasing mysterious hangs or crashes with no stack traces. The change is subtle, but possibly causes such kind of errors. R=viettrungluu@chromium.org,agl@chromium.org BUG=488291 Committed: https://crrev.com/0b35325d7b5e25f4942f79e3f4d6269c36f1c2e0 Cr-Commit-Position: refs/heads/master@{#333995}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M ipc/mojo/ipc_message_pipe_reader.cc View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Hajime Morrita
PTAL? Subtle change, bots say this is OK.
5 years, 6 months ago (2015-06-10 23:09:02 UTC) #1
Hajime Morrita
On 2015/06/10 23:09:02, Hajime Morrita wrote: > PTAL? Subtle change, bots say this is OK. ...
5 years, 6 months ago (2015-06-10 23:25:12 UTC) #2
agl
LGTM (mostly I'm just trusting that you know this code better than anyone at this ...
5 years, 6 months ago (2015-06-11 01:51:06 UTC) #3
Hajime Morrita
On 2015/06/11 01:51:06, agl wrote: > LGTM (mostly I'm just trusting that you know this ...
5 years, 6 months ago (2015-06-11 17:43:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175083002/1
5 years, 6 months ago (2015-06-11 17:43:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 18:39:08 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 18:41:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b35325d7b5e25f4942f79e3f4d6269c36f1c2e0
Cr-Commit-Position: refs/heads/master@{#333995}

Powered by Google App Engine
This is Rietveld 408576698