sky/engine/core/script/dom_dart_state.cc - Issue 1175053002: Fix shutdown crash in Sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/script/dom_dart_state.cc

Issue 1175053002: Fix shutdown crash in Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: more idiot-proof Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/script/dom_dart_state.cc

diff --git a/sky/engine/core/script/dom_dart_state.cc b/sky/engine/core/script/dom_dart_state.cc

index ecc429fb203f8b37c1d73f14103aea0156736fa1..439c7ca92691ae94088565d88245e2f9a9456d84 100644

--- a/sky/engine/core/script/dom_dart_state.cc

+++ b/sky/engine/core/script/dom_dart_state.cc

@@ -16,6 +16,10 @@ DOMDartState::DOMDartState(Document* document, const KURL& url)

}

DOMDartState::~DOMDartState() {

+ // We've already destroyed the isolate. Revoke any weak ptrs held by

+ // DartPersistentValues so they don't try to enter the destroyed isolate to

+ // clean themselves up.

+ weak_factory_.InvalidateWeakPtrs();

}

void DOMDartState::DidSetIsolate() {