Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: third_party/android_platform/README.chromium

Issue 1175033002: Ignore files with non-sane filenames in the Android stack symbolizing tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: readme Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/android_platform/README.chromium
diff --git a/third_party/android_platform/README.chromium b/third_party/android_platform/README.chromium
index 192b9d669be58213ff740e05bd156f18d878af15..854a36b583258af0518de8ba7040f4b6e2ca6054 100644
--- a/third_party/android_platform/README.chromium
+++ b/third_party/android_platform/README.chromium
@@ -26,7 +26,8 @@ include, but are not limited to, the following:
Added memoization of addr2line and objdump.
Added option to change the amount of symbolization done.
Updated output directories to use environment variable.
-When calling addr2line, check the symbol is a file (and not a directory).
+When calling addr2line, check the symbol is a file that looks like it contains
+ symbols.
Added support for parsing LOG(FATAL) and DCHECK errors and their
stack traces, as emitted by src/base/debug/stack_trace_android.cc
Added support for finding symbols when library is loaded directly from the APK.

Powered by Google App Engine
This is Rietveld 408576698