Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 1175013002: Invoke LeakSanitizer on teardown of RendererAccessibilityTest (Closed)

Created:
5 years, 6 months ago by Sami
Modified:
5 years, 6 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invoke LeakSanitizer on teardown of RendererAccessibilityTest Call LeakSanitizer before RenderViewTest::TearDown(), as the latter may leak WebKit objects when it shuts down V8. BUG=328552, 498407 Committed: https://crrev.com/afad64194903cd855acecbeb28c538d615b2571d Cr-Commit-Position: refs/heads/master@{#333746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M content/renderer/accessibility/renderer_accessibility_browsertest.cc View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sami
PTAL. See https://code.google.com/p/chromium/issues/detail?id=328552#c14 for some more background.
5 years, 6 months ago (2015-06-10 16:03:37 UTC) #2
dmazzoni
lgtm
5 years, 6 months ago (2015-06-10 16:09:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175013002/1
5 years, 6 months ago (2015-06-10 16:10:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 16:45:12 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 16:46:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afad64194903cd855acecbeb28c538d615b2571d
Cr-Commit-Position: refs/heads/master@{#333746}

Powered by Google App Engine
This is Rietveld 408576698