 Chromium Code Reviews
 Chromium Code Reviews Issue 1175003004:
  Change audio IPC enums from kConstantStyle to MACRO_STYLE  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1175003004:
  Change audio IPC enums from kConstantStyle to MACRO_STYLE  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: media/audio/audio_output_ipc.h | 
| diff --git a/media/audio/audio_output_ipc.h b/media/audio/audio_output_ipc.h | 
| index f85d8e0195325dfc3add33238bc77d56a9d85cc2..0262037feab68ac01b0f1f701e902425d80bf79f 100644 | 
| --- a/media/audio/audio_output_ipc.h | 
| +++ b/media/audio/audio_output_ipc.h | 
| @@ -12,23 +12,24 @@ | 
| namespace media { | 
| +// Current status of the audio output stream in the browser process. Browser | 
| +// sends information about the current playback state and error to the | 
| +// renderer process using this type. | 
| +enum AudioOutputIPCDelegateState { | 
| + AUDIO_OUTPUT_IPC_DELEGATE_STATE_PLAYING, | 
| + AUDIO_OUTPUT_IPC_DELEGATE_STATE_PAUSED, | 
| + AUDIO_OUTPUT_IPC_DELEGATE_STATE_ERROR, | 
| + AUDIO_OUTPUT_IPC_DELEGATE_STATE_MAX = AUDIO_OUTPUT_IPC_DELEGATE_STATE_ERROR | 
| 
Guido Urdaneta
2015/06/10 21:11:55
STATE_MAX, but it should be STATE_LAST
 
ncarter (slow)
2015/06/10 22:59:47
Thanks. I must have accidentally hit Ctrl+Z just b
 | 
| +}; | 
| + | 
| // Contains IPC notifications for the state of the server side | 
| // (AudioOutputController) audio state changes and when an AudioOutputController | 
| // has been created. Implemented by AudioOutputDevice. | 
| class MEDIA_EXPORT AudioOutputIPCDelegate { | 
| public: | 
| - // Current status of the audio output stream in the browser process. Browser | 
| - // sends information about the current playback state and error to the | 
| - // renderer process using this type. | 
| - enum State { | 
| - kPlaying, | 
| - kPaused, | 
| - kError, | 
| - kStateLast = kError | 
| - }; | 
| // Called when state of an audio stream has changed. | 
| - virtual void OnStateChanged(State state) = 0; | 
| + virtual void OnStateChanged(AudioOutputIPCDelegateState state) = 0; | 
| // Called when an audio stream has been created. | 
| // The shared memory |handle| points to a memory section that's used to |