Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1175003004: Change audio IPC enums from kConstantStyle to MACRO_STYLE (Closed)

Created:
5 years, 6 months ago by ncarter (slow)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change audio IPC enums from kConstantStyle to MACRO_STYLE. The Chromium style guide says not to use kConstantStyle. BUG=438023 Committed: https://crrev.com/bd111cd3e358aed78ec91073611dafc9d528a5e2 Cr-Commit-Position: refs/heads/master@{#334041}

Patch Set 1 #

Total comments: 2

Patch Set 2 : MAX -> LAST #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -61 lines) Patch
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/media/audio_messages.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/media/audio_input_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/audio_input_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/audio_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/audio_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/audio_message_filter_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/pepper/pepper_platform_audio_input.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_audio_input.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_audio_output.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_audio_output.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_input_device.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_input_device.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M media/audio/audio_input_ipc.h View 2 chunks +8 lines, -9 lines 0 comments Download
M media/audio/audio_output_device.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_device.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M media/audio/audio_output_ipc.h View 1 2 1 chunk +11 lines, -10 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
ncarter (slow)
guidou, please take a look
5 years, 6 months ago (2015-06-10 20:29:34 UTC) #2
Guido Urdaneta
https://codereview.chromium.org/1175003004/diff/1/media/audio/audio_output_ipc.h File media/audio/audio_output_ipc.h (right): https://codereview.chromium.org/1175003004/diff/1/media/audio/audio_output_ipc.h#newcode22 media/audio/audio_output_ipc.h:22: AUDIO_OUTPUT_IPC_DELEGATE_STATE_MAX = AUDIO_OUTPUT_IPC_DELEGATE_STATE_ERROR STATE_MAX, but it should be STATE_LAST
5 years, 6 months ago (2015-06-10 21:11:55 UTC) #3
Guido Urdaneta
On 2015/06/10 21:11:55, guidou wrote: > https://codereview.chromium.org/1175003004/diff/1/media/audio/audio_output_ipc.h > File media/audio/audio_output_ipc.h (right): > > https://codereview.chromium.org/1175003004/diff/1/media/audio/audio_output_ipc.h#newcode22 > ...
5 years, 6 months ago (2015-06-10 22:54:58 UTC) #4
ncarter (slow)
Thanks! https://codereview.chromium.org/1175003004/diff/1/media/audio/audio_output_ipc.h File media/audio/audio_output_ipc.h (right): https://codereview.chromium.org/1175003004/diff/1/media/audio/audio_output_ipc.h#newcode22 media/audio/audio_output_ipc.h:22: AUDIO_OUTPUT_IPC_DELEGATE_STATE_MAX = AUDIO_OUTPUT_IPC_DELEGATE_STATE_ERROR On 2015/06/10 21:11:55, guidou wrote: ...
5 years, 6 months ago (2015-06-10 22:59:47 UTC) #5
ncarter (slow)
dalecurtis: Please approve this boring patch for media/... and content/.../media/... bbudge: Please approve this boring ...
5 years, 6 months ago (2015-06-10 23:12:08 UTC) #6
ncarter (slow)
dalecurtis: Please approve this boring patch for media/... and content/.../media/... bbudge: Please approve this boring ...
5 years, 6 months ago (2015-06-10 23:12:36 UTC) #8
bbudge
content/renderer/pepper LGTM
5 years, 6 months ago (2015-06-10 23:18:57 UTC) #9
DaleCurtis
lgtm
5 years, 6 months ago (2015-06-11 00:00:48 UTC) #10
ncarter (slow)
dcheng: please review content/common/media/audio_messages.h
5 years, 6 months ago (2015-06-11 03:53:49 UTC) #12
dcheng
IPC changes lgtm Maybe add some context to the CL description (I assume this is ...
5 years, 6 months ago (2015-06-11 17:07:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175003004/20001
5 years, 6 months ago (2015-06-11 18:53:14 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/70247)
5 years, 6 months ago (2015-06-11 19:03:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175003004/40001
5 years, 6 months ago (2015-06-11 20:39:57 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-11 21:45:00 UTC) #21
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 21:45:58 UTC) #22
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/bd111cd3e358aed78ec91073611dafc9d528a5e2
Cr-Commit-Position: refs/heads/master@{#334041}

Powered by Google App Engine
This is Rietveld 408576698