Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1174993002: Fixes viewmanager tests on android (Closed)

Created:
5 years, 6 months ago by sky
Modified:
5 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes viewmanager tests on android There were two things causing flake: . The bounds of the root asynchronously changes. . Similarly the metrics are asynchronously available. As tests expect certain things to happen in a certain order these were causing problems. As we don't care about these cases I've ignored tracking them. This makes the test cleanly pass now. I also added --repeat-count to the apptest_runner. BUG=497920 TEST=test only change R=msw@chromium.org Committed: https://crrev.com/0216c9f87af7d6f25265cd93b34071fb8268db21 Cr-Commit-Position: refs/heads/master@{#333793}

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 7

Patch Set 3 : wrap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -158 lines) Patch
M components/view_manager/view_manager_service_apptest.cc View 1 2 20 chunks +26 lines, -141 lines 0 comments Download
M mojo/tools/apptest_runner.py View 2 chunks +23 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
sky
5 years, 6 months ago (2015-06-10 15:29:36 UTC) #1
msw
https://codereview.chromium.org/1174993002/diff/20001/components/view_manager/view_manager_service_apptest.cc File components/view_manager/view_manager_service_apptest.cc (right): https://codereview.chromium.org/1174993002/diff/20001/components/view_manager/view_manager_service_apptest.cc#newcode314 components/view_manager/view_manager_service_apptest.cc:314: // The bounds of the root may change during ...
5 years, 6 months ago (2015-06-10 18:42:05 UTC) #2
sky
https://codereview.chromium.org/1174993002/diff/20001/components/view_manager/view_manager_service_apptest.cc File components/view_manager/view_manager_service_apptest.cc (right): https://codereview.chromium.org/1174993002/diff/20001/components/view_manager/view_manager_service_apptest.cc#newcode324 components/view_manager/view_manager_service_apptest.cc:324: // Don't track the metrics as they are available ...
5 years, 6 months ago (2015-06-10 19:36:36 UTC) #3
msw
lgtm with q (pinged) https://codereview.chromium.org/1174993002/diff/20001/components/view_manager/view_manager_service_apptest.cc File components/view_manager/view_manager_service_apptest.cc (right): https://codereview.chromium.org/1174993002/diff/20001/components/view_manager/view_manager_service_apptest.cc#newcode314 components/view_manager/view_manager_service_apptest.cc:314: // The bounds of the ...
5 years, 6 months ago (2015-06-10 19:49:23 UTC) #4
sky
https://codereview.chromium.org/1174993002/diff/20001/components/view_manager/view_manager_service_apptest.cc File components/view_manager/view_manager_service_apptest.cc (right): https://codereview.chromium.org/1174993002/diff/20001/components/view_manager/view_manager_service_apptest.cc#newcode314 components/view_manager/view_manager_service_apptest.cc:314: // The bounds of the root may change during ...
5 years, 6 months ago (2015-06-10 19:54:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174993002/40001
5 years, 6 months ago (2015-06-10 19:55:07 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-10 20:42:18 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 20:43:06 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0216c9f87af7d6f25265cd93b34071fb8268db21
Cr-Commit-Position: refs/heads/master@{#333793}

Powered by Google App Engine
This is Rietveld 408576698