Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1174973003: Measure usage of FormData.append(name, blob, filename) (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, arv+blink, vivekg_samsung, blink-reviews-html_chromium.org, vivekg, dglazkov+blink, Inactive
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Measure usage of FormData.append(name, blob, filename) As requested by Anne van Kesteren: https://bugzilla.mozilla.org/show_bug.cgi?id=1162658#c47 Per spec the blob argument cannot be null, but in Blink it can without [TypeChecking=Interface], for FormData.append(name, null, filename). (With no filename argument it is instead taken as the USVString "null".) This is almost certainly safe to fix, but it's easy to measure here. BUG=498790 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197268

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M Source/core/frame/UseCounter.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/html/DOMFormData.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/DOMFormData.cpp View 2 chunks +17 lines, -1 line 0 comments Download
M Source/core/html/FormData.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174973003/1
5 years, 6 months ago (2015-06-10 15:19:04 UTC) #2
philipj_slow
sigbjornf@, PTAL, I see you've poked at FormData a few times.
5 years, 6 months ago (2015-06-10 15:31:48 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-10 16:35:31 UTC) #6
philipj_slow
Friendly ping.
5 years, 6 months ago (2015-06-15 07:59:46 UTC) #7
philipj_slow
jl@, PTAL.
5 years, 6 months ago (2015-06-17 13:23:18 UTC) #9
Jens Widell
LGTM
5 years, 6 months ago (2015-06-17 13:32:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174973003/20001
5 years, 6 months ago (2015-06-17 13:40:41 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 16:03:44 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197268

Powered by Google App Engine
This is Rietveld 408576698