Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(32)

Issue 1174933002: Implement ShadowRoot.delegatesFocus 2/4 (slide focus on mouse click) (Closed)

Created:
4 years, 10 months ago by kochi
Modified:
4 years, 10 months ago
Reviewers:
hayato
CC:
blink-reviews, arv+blink, vivekg, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Implement ShadowRoot.delegatesFocus 2/4 (slide focus on mouse click) This Implements sliding focus from shadow host to inner element of its shadow root. When delegatesFocus is set to true for a shadow root, its shadow host delegates mouse click-initiated focus to its internal focusable element. This depends on previous CL. https://codereview.chromium.org/1174893002/ Remaining implementations will follow: 3/4 Slide focus on focus() method 4/4 Match CSS :focus for shadow host Design doc: https://docs.google.com/document/d/1k93Ez6yNSyWQDtGjdJJqTBPmljk9l2WS3JTe5OHHB50/edit BUG=496005 TEST=fast/dom/shadow/focus-slide-on-shadow-host.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196925

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -0 lines) Patch
A LayoutTests/fast/dom/shadow/focus-slide-on-shadow-host.html View 1 chunk +112 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/focus-slide-on-shadow-host-expected.txt View 1 chunk +30 lines, -0 lines 0 comments Download
M Source/core/input/EventHandler.h View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/input/EventHandler.cpp View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174933002/1
4 years, 10 months ago (2015-06-10 11:13:29 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-10 12:33:06 UTC) #4
kochi
PTAL
4 years, 10 months ago (2015-06-11 04:05:12 UTC) #6
hayato
lgtm
4 years, 10 months ago (2015-06-11 04:26:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174933002/20001
4 years, 10 months ago (2015-06-11 07:14:44 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-11 08:19:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196925

Powered by Google App Engine
This is Rietveld 408576698