Source/web/WebViewImpl.cpp - Issue 117493002: Invert the owning relationship between WebFrame and Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 117493002: Invert the owning relationship between WebFrame and Frame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 66df1cc5168ea1fc2f90ec2e324f743a4aacc1d3..90b794ad98a9b90f59d1e412771e5147fbacecaa 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -290,9 +290,6 @@ void WebView::didExitModalLoop()

void WebViewImpl::setMainFrame(WebFrame* frame)

{

- // NOTE: The WebFrameImpl takes a reference to itself within

- // initializeAsMainFrame() and releases that reference once the

- // corresponding Frame is destroyed.

toWebFrameImpl(frame)->initializeAsMainFrame(page());

}

« no previous file with comments | « Source/web/WebFrameImpl.cpp ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »