Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: Source/core/inspector/InspectorOverlay.cpp

Issue 117493002: Invert the owning relationship between WebFrame and Frame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorOverlay.cpp
diff --git a/Source/core/inspector/InspectorOverlay.cpp b/Source/core/inspector/InspectorOverlay.cpp
index 34f6c98f593fae0a8bebd06c7e3046fa38830b03..ab5430dac594e453bac480c5516d5c37a47859af 100644
--- a/Source/core/inspector/InspectorOverlay.cpp
+++ b/Source/core/inspector/InspectorOverlay.cpp
@@ -681,7 +681,10 @@ bool InspectorOverlay::getBoxModel(Node* node, Vector<FloatQuad>* quads)
void InspectorOverlay::freePage()
{
- m_overlayPage.clear();
+ if (m_overlayPage) {
+ m_overlayPage->mainFrame()->loader().frameDetached();
eseidel 2013/12/28 01:18:40 Is it too late to do this during Page destruction?
dcheng 2013/12/28 01:51:05 One possible alternative is to move this into Page
+ m_overlayPage.clear();
+ }
m_overlayChromeClient.clear();
m_timer.stop();
}

Powered by Google App Engine
This is Rietveld 408576698