Source/web/tests/WebFrameTest.cpp - Issue 117493002: Invert the owning relationship between WebFrame and Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 117493002: Invert the owning relationship between WebFrame and Frame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Comment clarity? Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 9e24b00bfe4bd30120209c7312d0f8aeb696e95a..977e4b9f8b6ccc930c5d1bf51d23e518e54769cc 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -3191,7 +3191,7 @@ TEST_F(WebFrameTest, FindOnDetachedFrame)

WebFindOptions options;

WebString searchText = WebString::fromUTF8(kFindString);

WebFrameImpl* mainFrame = toWebFrameImpl(webViewHelper.webView()->mainFrame());

- WebFrameImpl* secondFrame = toWebFrameImpl(mainFrame->traverseNext(false));

+ RefPtr<WebFrameImpl> secondFrame = toWebFrameImpl(mainFrame->traverseNext(false));

RefPtr<WebCore::Frame> holdSecondFrame = secondFrame->frame();

// Detach the frame before finding.

« Source/web/WebFrameImpl.h ('K') | « Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »