Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 1174923002: [test] Use generator to accelerate test runner startup. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Use generator to accelerate test runner startup. This saves >1s for mjsunit and >10s for test262. Committed: https://crrev.com/816b5b1761fdb2c03bca7b54c1a7bb2923addb2f Cr-Commit-Position: refs/heads/master@{#28904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M tools/testrunner/local/execution.py View 2 chunks +15 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Achenbach
PTAL
5 years, 6 months ago (2015-06-10 10:07:48 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174923002/1
5 years, 6 months ago (2015-06-10 10:07:49 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-10 10:34:34 UTC) #6
Jakob Kummerow
Nice'n'easy. LGTM.
5 years, 6 months ago (2015-06-10 10:55:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174923002/1
5 years, 6 months ago (2015-06-10 11:13:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 11:15:17 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 11:15:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/816b5b1761fdb2c03bca7b54c1a7bb2923addb2f
Cr-Commit-Position: refs/heads/master@{#28904}

Powered by Google App Engine
This is Rietveld 408576698