DescriptionX87: [date] Refactor the %_DateField intrinsic to be optimizable.
port e4782a9b468258344d512a5f7dadbf1584928849 (r28782)
original commit message:
Previously the %_DateField intrinsic would also check the object and
throw an exception if you happen to pass something that is not a valid
JSDate, which (a) violates our policy for instrinsics and (b) is hard to
optimize in TurboFan (even Crankshaft has a hard time, but there we will
never inline the relevant builtins, so it doesn't show up). The throwing
part is now a separate intrinsics %_ThrowIfNotADate that throws an
exception in full codegen and deoptimizes in Crankshaft, which means the
code for the current use cases is roughly the same (modulo some register
renamings/gap moves).
BUG=
R=weiliang.lin@intel.com
Committed: https://chromium.googlesource.com/v8/v8/+/c8b7c2496d38a220354a54278a64655fce898b9f
Patch Set 1 #
Messages
Total messages: 9 (3 generated)
|