Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1174913002: X87: [date] Refactor the %_DateField intrinsic to be optimizable. (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 6 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [date] Refactor the %_DateField intrinsic to be optimizable. port e4782a9b468258344d512a5f7dadbf1584928849 (r28782) original commit message: Previously the %_DateField intrinsic would also check the object and throw an exception if you happen to pass something that is not a valid JSDate, which (a) violates our policy for instrinsics and (b) is hard to optimize in TurboFan (even Crankshaft has a hard time, but there we will never inline the relevant builtins, so it doesn't show up). The throwing part is now a separate intrinsics %_ThrowIfNotADate that throws an exception in full codegen and deoptimizes in Crankshaft, which means the code for the current use cases is roughly the same (modulo some register renamings/gap moves). BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/c8b7c2496d38a220354a54278a64655fce898b9f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -18 lines) Patch
M src/x87/full-codegen-x87.cc View 3 chunks +25 lines, -11 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
chunyang.dai
PTAL
5 years, 6 months ago (2015-06-11 08:41:04 UTC) #2
Weiliang
lgtm
5 years, 6 months ago (2015-06-11 08:58:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174913002/1
5 years, 6 months ago (2015-06-11 08:58:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/1219)
5 years, 6 months ago (2015-06-11 09:19:43 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c8b7c2496d38a220354a54278a64655fce898b9f Cr-Commit-Position: refs/heads/master@{#28948}
5 years, 6 months ago (2015-06-11 15:48:32 UTC) #8
chunyang.dai
5 years, 6 months ago (2015-06-11 15:48:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c8b7c2496d38a220354a54278a64655fce898b9f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698