Implement ShadowRoot.delegatesFocus 1/4 (focus navigation)

Implement ShadowRoot.delegatesFocus 1/4 (focus navigation)

This Implements 'delegatesFocus' for ShadowRoot.

When delegatesFocus is set to true for a shadow root, its shadow host
delegates focusing behavior to its internal focusable element.

Note: this almost corresponds to old implementation (tabStop), except
that when delegatesFocus = true, the shadow host becomes focusable
regardless of whether tabindex attribute is set or not.

Remaining implementations will follow:
2/4 Slide focus on mouse click
3/4 Slide focus on focus() method
4/4 Match CSS :focus for shadow host

Design doc:
https://docs.google.com/document/d/1k93Ez6yNSyWQDtGjdJJqTBPmljk9l2WS3JTe5OHHB50/edit

BUG=496005
TEST=fast/dom/shadow/focus-navigation-with-delegatesFocus.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196919

[kochi, 2015-06-10 09:06:33]

The CQ bit was checked by kochi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-10 09:06:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1174893002/1

[kochi, 2015-06-10 09:15:29]

kochi@chromium.org changed reviewers:
+ hayato@chromium.org

[kochi, 2015-06-10 09:15:30]

PTAL

[commit-bot: I haz the power, 2015-06-10 10:19:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-10 10:19:30]

Dry run: This issue passed the CQ dry run.

[kochi, 2015-06-11 01:59:16]

The CQ bit was checked by kochi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-11 01:59:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1174893002/20001

[commit-bot: I haz the power, 2015-06-11 02:52:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 02:52:20]

Dry run: Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[kochi, 2015-06-11 04:06:00]

The CQ bit was checked by kochi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-11 04:06:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1174893002/20001

[hayato, 2015-06-11 04:24:24]

lgtm

[commit-bot: I haz the power, 2015-06-11 05:29:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 05:29:32]

Dry run: This issue passed the CQ dry run.

[kochi, 2015-06-11 05:31:25]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2015-06-11 05:31:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1174893002/20001

[kochi, 2015-06-11 05:34:55]

kochi@chromium.org changed reviewers:
+ tkent@chromium.org

[kochi, 2015-06-11 05:35:25]

tkent-san,

Could you review for Source/platform/RuntimeEnabledFeatures.in?

[commit-bot: I haz the power, 2015-06-11 05:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-11 05:37:45]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

[tkent, 2015-06-11 05:38:27]

lgtm

https://codereview.chromium.org/1174893002/diff/20001/Source/core/dom/Element...
File Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/1174893002/diff/20001/Source/core/dom/Element...
Source/core/dom/Element.cpp:1822: return
PassRefPtrWillBeRawPtr<ShadowRoot>(shadowRoot);
nit: return shadowRoot.release();

[kochi, 2015-06-11 05:44:23]

Thanks for the review!

https://codereview.chromium.org/1174893002/diff/20001/Source/core/dom/Element...
File Source/core/dom/Element.cpp (right):

https://codereview.chromium.org/1174893002/diff/20001/Source/core/dom/Element...
Source/core/dom/Element.cpp:1822: return
PassRefPtrWillBeRawPtr<ShadowRoot>(shadowRoot);
On 2015/06/11 05:38:27, tkent wrote:
> nit: return shadowRoot.release();

Done.

[kochi, 2015-06-11 05:44:38]

The CQ bit was checked by kochi@chromium.org

[kochi, 2015-06-11 05:44:38]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
hayato@chromium.org
Link to the patchset: https://codereview.chromium.org/1174893002/#ps40001
(title: "fix for nit review comment")

[commit-bot: I haz the power, 2015-06-11 05:44:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1174893002/40001

[commit-bot: I haz the power, 2015-06-11 07:01:20]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196919