Refactoring: Remove StyledMarkupAccumulator::appendString and add appendNewLine

Source/core/editing/StyledMarkupSerializer.cpp

Index: Source/core/editing/StyledMarkupSerializer.cpp
diff --git a/Source/core/editing/StyledMarkupSerializer.cpp b/Source/core/editing/StyledMarkupSerializer.cpp
index ce77ecda8eb6538f9496158c167a5d5146390277..10858616ea91d2fd1c6131d0cc4c8eff41c5939e 100644
--- a/Source/core/editing/StyledMarkupSerializer.cpp
+++ b/Source/core/editing/StyledMarkupSerializer.cpp
@@ -130,7 +130,7 @@ String StyledMarkupSerializer<Strategy>::createMarkup()
         if (visibleStart == visibleEnd.previous())
             return interchangeNewlineString;
 
-        markupAccumulator.appendString(interchangeNewlineString);
+        markupAccumulator.appendNewLine();

[yosin_UTC9, 2015/06/10 07:17:32]

If we move this before L130 and change |return interchangeNewline| in L131 and
L138 to |return markupAccumlator.takeResults()|, we don't need to have static
variable interchangeNewlineString in L120.

I expect above change in next patch. ;-)

BTW, it seems if you have above patch, another patch can be submit in parallel.

[hajimehoshi, 2015/06/10 07:28:31]

Good catch. Done.

         firstNode = visibleStart.next().deepEquivalent().deprecatedNode();
 
         if (pastEnd && Strategy::PositionType::beforeNode(firstNode).compareTo(Strategy::PositionType::beforeNode(pastEnd)) >= 0) {
@@ -186,7 +186,7 @@ String StyledMarkupSerializer<Strategy>::createMarkup()
 
     // FIXME: The interchange newline should be placed in the block that it's in, not after all of the content, unconditionally.
     if (m_shouldAnnotate == AnnotateForInterchange && needInterchangeNewlineAt(visibleEnd))
-        markupAccumulator.appendString(interchangeNewlineString);
+        markupAccumulator.appendNewLine();
 
     return markupAccumulator.takeResults();
 }