Refactoring: Remove StyledMarkupAccumulator::appendString and add appendNewLine

Refactoring: Remove StyledMarkupAccumulator::appendString and add appendNewLine

appendString is more generic than necessary. This CL replaces it with
appendNewLine.

BUG=n/a
TEST=n/a; no behavior change

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196855

[hajimehoshi, 2015-06-10 07:01:18]

hajimehoshi@chromium.org changed reviewers:
+ yosin@chromium.org

[hajimehoshi, 2015-06-10 07:01:18]

PTAL

[yosin_UTC9, 2015-06-10 07:06:33]

I think appendInterchangeNewline() is better name since 
 - use |interchangeNewlineString| in other places.
 - term "newline" is confusing with U+000A.

https://codereview.chromium.org/1174873002/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupAccumulator.cpp (right):

https://codereview.chromium.org/1174873002/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupAccumulator.cpp:266: void
StyledMarkupAccumulator::appendNewLine()
s/NewLine/newline/
as "interchange Newline String" in below.

[hajimehoshi, 2015-06-10 07:16:30]

Thanks!

https://codereview.chromium.org/1174873002/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupAccumulator.cpp (right):

https://codereview.chromium.org/1174873002/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupAccumulator.cpp:266: void
StyledMarkupAccumulator::appendNewLine()
On 2015/06/10 07:06:33, Yosi_UTC9 wrote:
> s/NewLine/newline/
> as "interchange Newline String" in below.

Done.

[yosin_UTC9, 2015-06-10 07:17:32]

https://codereview.chromium.org/1174873002/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupSerializer.cpp (right):

https://codereview.chromium.org/1174873002/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupSerializer.cpp:133:
markupAccumulator.appendNewLine();
If we move this before L130 and change |return interchangeNewline| in L131 and
L138 to |return markupAccumlator.takeResults()|, we don't need to have static
variable interchangeNewlineString in L120.

I expect above change in next patch. ;-)

BTW, it seems if you have above patch, another patch can be submit in parallel.

[hajimehoshi, 2015-06-10 07:28:31]

https://codereview.chromium.org/1174873002/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupSerializer.cpp (right):

https://codereview.chromium.org/1174873002/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupSerializer.cpp:133:
markupAccumulator.appendNewLine();
On 2015/06/10 07:17:32, Yosi_UTC9 wrote:
> If we move this before L130 and change |return interchangeNewline| in L131 and
> L138 to |return markupAccumlator.takeResults()|, we don't need to have static
> variable interchangeNewlineString in L120.
> 
> I expect above change in next patch. ;-)
> 
> BTW, it seems if you have above patch, another patch can be submit in
parallel.

Good catch. Done.

[yosin_UTC9, 2015-06-10 07:47:44]

lgtm

[yosin_UTC9, 2015-06-10 07:47:48]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-06-10 07:47:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1174873002/60001

[commit-bot: I haz the power, 2015-06-10 10:15:52]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196855