Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: public/platform/modules/bluetooth/WebBluetooth.h

Issue 1174843002: Add tests for RequestDeviceOptions and clean up. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@pinned
Patch Set: Comment how the ScanFilterCheckingAdapter test works Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/modules/bluetooth/WebBluetooth.h
diff --git a/public/platform/modules/bluetooth/WebBluetooth.h b/public/platform/modules/bluetooth/WebBluetooth.h
index af88258b3ddd10c45776b4de91e21b597a174ca8..cc7a2e0dedb0a1b31cd0c624348b6643a56d2155 100644
--- a/public/platform/modules/bluetooth/WebBluetooth.h
+++ b/public/platform/modules/bluetooth/WebBluetooth.h
@@ -45,10 +45,7 @@ public:
// BluetoothDiscovery Methods:
// See https://webbluetoothcg.github.io/web-bluetooth/#idl-def-bluetoothdiscovery
// WebBluetoothRequestDeviceCallbacks ownership transferred to the client.
- virtual void requestDevice(const WebRequestDeviceOptions&, WebBluetoothRequestDeviceCallbacks* callbacks) { requestDevice(callbacks); }
- // TODO(jyasskin): Remove this overload after
- // https://codereview.chromium.org/1172853004/ lands.
- virtual void requestDevice(WebBluetoothRequestDeviceCallbacks*) { }
+ virtual void requestDevice(const WebRequestDeviceOptions&, WebBluetoothRequestDeviceCallbacks*) { }
// BluetoothDevice methods:
// See https://webbluetoothcg.github.io/web-bluetooth/#idl-def-bluetoothdevice
« LayoutTests/bluetooth/requestDevice.html ('K') | « LayoutTests/bluetooth/requestDevice.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698