public/platform/modules/bluetooth/WebBluetooth.h - Issue 1174843002: Add tests for RequestDeviceOptions and clean up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/modules/bluetooth/WebBluetooth.h

Issue 1174843002: Add tests for RequestDeviceOptions and clean up. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@pinned

Patch Set: Turn into the 3rd side of the patch. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: public/platform/modules/bluetooth/WebBluetooth.h

diff --git a/public/platform/modules/bluetooth/WebBluetooth.h b/public/platform/modules/bluetooth/WebBluetooth.h

index 5d9a9f730f1c11ae39a59051e23fcce3b0e8c7ac..af051fe6642990a70fc92aaf0410eb85f594d926 100644

--- a/public/platform/modules/bluetooth/WebBluetooth.h

+++ b/public/platform/modules/bluetooth/WebBluetooth.h

@@ -45,10 +45,7 @@ public:

// BluetoothDiscovery Methods:

// See https://webbluetoothcg.github.io/web-bluetooth/#idl-def-bluetoothdiscovery

// WebBluetoothRequestDeviceCallbacks ownership transferred to the client.

- virtual void requestDevice(const WebRequestDeviceOptions&, WebBluetoothRequestDeviceCallbacks* callbacks) { requestDevice(callbacks); }

- // TODO(jyasskin): Remove this overload and make the other abstract after

- // https://codereview.chromium.org/1172853004/ lands.

- virtual void requestDevice(WebBluetoothRequestDeviceCallbacks*) { }

+ virtual void requestDevice(const WebRequestDeviceOptions&, WebBluetoothRequestDeviceCallbacks*) = 0;

// BluetoothDevice methods:

// See https://webbluetoothcg.github.io/web-bluetooth/#idl-def-bluetoothdevice

« no previous file with comments | « LayoutTests/bluetooth/requestDevice.html ('k') | no next file » | no next file with comments »