Browser Plugin: Refactor BrowserPluginEmbedder to allow creating guests with openers

content/browser/browser_plugin/browser_plugin_embedder.h

Index: content/browser/browser_plugin/browser_plugin_embedder.h
diff --git a/content/browser/browser_plugin/browser_plugin_embedder.h b/content/browser/browser_plugin/browser_plugin_embedder.h
index b4e846aef1c953bbb254d29e1d00dbae8a61e552..e33fba89ca9f7337ea00aca04722d01dd33726bf 100644
--- a/content/browser/browser_plugin/browser_plugin_embedder.h
+++ b/content/browser/browser_plugin/browser_plugin_embedder.h
@@ -57,6 +57,19 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver,
   static BrowserPluginEmbedder* Create(WebContentsImpl* web_contents,
                                        RenderViewHost* render_view_host);
 
+  void CreateGuest(int instance_id,

[sadrul, 2013/01/07 15:09:54]

Doc

[Fady Samuel, 2013/01/08 17:00:49]

Done.

+                   int routing_id,
+                   BrowserPluginGuest* guest_opener,
+                   const BrowserPluginHostMsg_CreateGuest_Params& params);
+
+  // Returns a guest browser plugin delegate by its container ID specified
+  // in BrowserPlugin.
+  BrowserPluginGuest* GetGuestByInstanceID(int instance_id) const;
+
+  // Destroy the guest with the provided |instance_id|. Remove references to the
+  // guest in this BrowserPluginEmbedder.
+  void DestroyGuestByInstanceID(int instance_id);

[sadrul, 2013/01/07 15:09:54]

It doesn't look like either GuestGuestByInstanceID or Destroy... is called from
anywhere outside of BPEmbedder. Is exposing these in public necessary for the
follow-on patches?

[Fady Samuel, 2013/01/08 17:00:49]

This will be used by follow-on patches. I am making the simple changes here in
order to simply the review process in follow-on patches.

+
   // Overrides factory for testing. Default (NULL) value indicates regular
   // (non-test) environment.
   static void set_factory_for_testing(BrowserPluginHostFactory* factory) {
@@ -89,12 +102,8 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver,
   BrowserPluginEmbedder(WebContentsImpl* web_contents,
                         RenderViewHost* render_view_host);
 
-  // Returns a guest browser plugin delegate by its container ID specified
-  // in BrowserPlugin.
-  BrowserPluginGuest* GetGuestByInstanceID(int instance_id) const;
   // Adds a new guest web_contents to the embedder (overridable in test).
   virtual void AddGuest(int instance_id, WebContents* guest_web_contents);
-  void DestroyGuestByInstanceID(int instance_id);
   void CleanUp();
 
   // Called when visiblity of web_contents changes, so the embedder will