components/offline_pages/offline_page_archiver.cc - Issue 1174803002: [Offline] Adding archiver interface

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/offline_pages/offline_page_archiver.cc

Issue 1174803002: [Offline] Adding archiver interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@offline-pages-store

Patch Set: Addressing more feedback from dimich Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/offline_pages/offline_page_metadata_store.h"	5 #include "components/offline_pages/offline_page_archiver.h"

	6

6	7

7 namespace offline_pages {	8 namespace offline_pages {

8	9

9 OfflinePageMetadataStore::OfflinePageMetadataStore() {	10 OfflinePageArchiver::Request::~Request() {
	Dmitry Titov 2015/06/12 21:03:59 The remaining empty dtors can just go into .h file The remaining empty dtors can just go into .h file and this file is not needed then, unless you have a plan for it to grow... fgorski 2015/06/12 22:16:27 Done. Show quoted text On 2015/06/12 21:03:59, Dmitry Titov wrote: > The remaining empty dtors can just go into .h file and this file is not needed > then, unless you have a plan for it to grow... Done.
10 }	11 }

11	12

12 OfflinePageMetadataStore::~OfflinePageMetadataStore() {	13 OfflinePageArchiver::Client::~Client() {

	14 }

	15

	16 OfflinePageArchiver::~OfflinePageArchiver() {

13 }	17 }

14	18

15 } // namespace offline_pages	19 } // namespace offline_pages

OLD	NEW