Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11748023: M26 new bluetooth UI. List all bluetooth devices in detailed view and automatically discover all BT… (Closed)

Created:
7 years, 11 months ago by jennyz
Modified:
7 years, 11 months ago
Reviewers:
xiyuan, sadrul
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, keybuk
Visibility:
Public.

Description

M26 new bluetooth UI. List all bluetooth devices in detailed view and automatically discover all BT devices when BT detailed view bubble opens. BUG=130698 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175403

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase and nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -30 lines) Patch
M ash/system/bluetooth/tray_bluetooth.cc View 1 5 chunks +65 lines, -27 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/system/tray/test_system_tray_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/tray/test_system_tray_delegate.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/tray/tray_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/tray/tray_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/tray/tray_details_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/tray/tray_details_view.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M ash/system/tray/tray_views.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jennyz
7 years, 11 months ago (2013-01-03 23:29:35 UTC) #1
jennyz
7 years, 11 months ago (2013-01-03 23:30:43 UTC) #2
sadrul
LGTM https://codereview.chromium.org/11748023/diff/1/ash/system/bluetooth/tray_bluetooth.cc File ash/system/bluetooth/tray_bluetooth.cc (right): https://codereview.chromium.org/11748023/diff/1/ash/system/bluetooth/tray_bluetooth.cc#newcode187 ash/system/bluetooth/tray_bluetooth.cc:187: if (discovered_not_paired_devices_.size() > 0) { No braces needed
7 years, 11 months ago (2013-01-07 20:39:03 UTC) #3
jennyz
https://codereview.chromium.org/11748023/diff/1/ash/system/bluetooth/tray_bluetooth.cc File ash/system/bluetooth/tray_bluetooth.cc (right): https://codereview.chromium.org/11748023/diff/1/ash/system/bluetooth/tray_bluetooth.cc#newcode187 ash/system/bluetooth/tray_bluetooth.cc:187: if (discovered_not_paired_devices_.size() > 0) { On 2013/01/07 20:39:03, sadrul ...
7 years, 11 months ago (2013-01-07 20:57:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/11748023/7001
7 years, 11 months ago (2013-01-07 20:57:55 UTC) #5
commit-bot: I haz the power
Presubmit check for 11748023-7001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-07 20:58:06 UTC) #6
jennyz
xiyuan, would you please review the change chrome/browser/chromeos/system/ash_system_tray_delegate.cc? It is quite straight forward.
7 years, 11 months ago (2013-01-07 21:01:40 UTC) #7
xiyuan
chrome/browser/chromeos/system/ash_system_tray_delegate.cc LGTM
7 years, 11 months ago (2013-01-07 21:05:00 UTC) #8
commit-bot: I haz the power
7 years, 11 months ago (2013-01-07 21:25:58 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698