tests/corelib/compare_to2_test.dart - Issue 11748016: Make ~/, round, ceil, floor, truncate return ints. Remove toInt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/corelib/compare_to2_test.dart

Issue 11748016: Make ~/, round, ceil, floor, truncate return ints. Remove toInt. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart

Patch Set: Checked mode fixes. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/corelib/compare_to2_test.dart

diff --git a/tests/corelib/compare_to2_test.dart b/tests/corelib/compare_to2_test.dart

index 8100fc46b61c5f9f7200e7415a00c9129c957103..3d1353c2957bbca9715794e3c3d83cbb8c62be22 100644

--- a/tests/corelib/compare_to2_test.dart

+++ b/tests/corelib/compare_to2_test.dart

@@ -13,14 +13,14 @@ main() {

var maxFraction = 0.9999999999999999;

var minAbove1 = 1.0000000000000002;

var maxNonInt = 4503599627370495.5;

- var maxNonIntFloorAsDouble = maxNonInt.floor();

- var maxNonIntFloorAsInt = maxNonIntFloorAsDouble.toInt();

+ var maxNonIntFloorAsInt = maxNonInt.floor();

+ var maxNonIntFloorAsDouble = maxNonIntFloorAsInt.toDouble();

var maxExactIntAsDouble = 9007199254740992.0;

var maxExactIntAsInt = 9007199254740992;

var two53 = 1 << 53; // Same as maxExactIntAsInt.

var two53p1 = two53 + 1;

var maxFiniteAsDouble = 1.7976931348623157e+308;

- var maxFiniteAsInt = maxFiniteAsDouble.toInt();

+ var maxFiniteAsInt = maxFiniteAsDouble.truncate();

Lasse Reichstein Nielsen 2013/01/04 10:29:42 Curious. This is actually a use-case for "toInt" :

int huge = 1 << 2000;

int hugeP1 = huge + 1;

var inf = double.INFINITY;

« sdk/lib/core/num.dart ('K') | « tests/corelib/collection_to_string_test.dart ('k') | tests/language/arithmetic_test.dart » ('j') | tools/testing/dart/test_progress.dart » ('J')