Make ~/, round, ceil, floor, truncate return ints. Remove toInt.

utils/tests/string_encoding/benchmark_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * The results of a single block of tests (count times run, overall time).
  */
 class BlockSample {
   BlockSample(this.count, this.durationNanos);
   int count;
@@ skipping 40 matching lines @@
       double n = source.length.toDouble();
       double sumY = BlockSample._totalTime(source).toDouble();
       double sumXSquared = BlockSample._sum(source,
           int _(BlockSample s) => s.count * s.count).toDouble();
       double sumX = BlockSample._totalCount(source).toDouble();
       double sumXY = BlockSample._sum(source,
           int _(BlockSample s) => s.durationNanos * s.count).toDouble();
 
       overheadNanos =
           ((((sumY * sumXSquared) - (sumX * sumXY)) /
-          ((n * sumXSquared) - (sumX * sumX))) / source.length).toInt();
+          ((n * sumXSquared) - (sumX * sumX))) / source.length).truncate();

[Lasse Reichstein Nielsen, 2013/01/04 10:29:42]

Indent by one more here.

 
       perRequestNanos =
           (((n * sumXY) - (sumX * sumY)) /
-          ((n * sumXSquared) - (sumX * sumX))).toInt();
+          ((n * sumXSquared) - (sumX * sumX))).truncate();

[Lasse Reichstein Nielsen, 2013/01/04 10:29:42]

Ditto.

     }
   }
 
   bool isValid() => overheadNanos >= 0 && perRequestNanos >= 0;
 
   int overheadNanos;
   int perRequestNanos;
   int repsFor(int targetDurationNanos, [int blocksize = -1]) {
     if (blocksize <= 0) {
-      return ((targetDurationNanos - overheadNanos) / perRequestNanos).toInt();
+      return ((targetDurationNanos - overheadNanos) / perRequestNanos).truncate();

[Lasse Reichstein Nielsen, 2013/01/04 10:29:42]

Long line. Use ~/ ?

     } else {
       int blockTime = overheadNanos + (blocksize * perRequestNanos);
       int fullBlocks = targetDurationNanos ~/ blockTime;
       int extraReps =
           ((targetDurationNanos - (fullBlocks * blockTime)) - overheadNanos)
           ~/ perRequestNanos;
-      return ((fullBlocks * blocksize) + extraReps).toInt();
+      return ((fullBlocks * blocksize) + extraReps).truncate();

[Lasse Reichstein Nielsen, 2013/01/04 10:29:42]

All operands are int, so drop truncate.

     }
   }
 }
 
 /**
  * Report overall test performance
  */
 class TestReport {
   TestReport(this.id, this.desc, this.warmup, this.results) {
     spaceChar = " ".charCodes[0];
   }
 
   int spaceChar;
 
   int resultsCount() => BlockSample._totalCount(results);
 
   int resultsNanos() => BlockSample._totalTime(results);
 
   int resultsBestNanos() {
     BlockSample best = bestBlock(results);
     return best.durationNanos ~/ best.count;
   }
 
   int resultsMeanNanos() =>
-      (BlockSample._totalTime(results) /
-      BlockSample._totalCount(results)).toInt();
+      (BlockSample._totalTime(results) ~/
+      BlockSample._totalCount(results));

[Lasse Reichstein Nielsen, 2013/01/04 10:29:42]

Indent by 1 more, or put on same line if possible.

[floitsch, 2013/03/11 13:39:15]

Done in a different CL.

 
   int resultsWorstNanos() {
     BlockSample worst = worstBlock(results);
     return worst.durationNanos / worst.count;
   }
 
   int warmupBestNanos() {
     BlockSample best = bestBlock(warmup);
     return best.durationNanos / best.count;
   }
@@ skipping 59 matching lines @@
     outCodes.insertRange(0, width, spaceChar);
     outCodes.setRange(Math.max(0, width - s.length), Math.min(width, s.length),
         s.charCodes);
     return new String.fromCharCodes(outCodes);
   }
 
   static String _stringifyDoubleAsInt(double val) {
     if (val.isInfinite || val.isNaN) {
       return "NaN";
     } else {
-      return val.toInt().toString();
+      return val.truncate().toString();

[Lasse Reichstein Nielsen, 2013/01/04 10:29:42]

.toStringAsFixed(0)

     }
   }
 
   String id;
   String desc;
   List<BlockSample> warmup;
   List<BlockSample> results;
 }
 
 class Runner {
@@ skipping 251 matching lines @@
         _(TestReport r) => r.printReport() : reportHandler;
   }
 
   Function _reportHandler;
   Function get reportHandler => _reportHandler;
   int _warmup;
   int _targetTimeMs;
   int _minSampleTimeMs;
   int _blocksize;
 }