[Android WebView] Close InputStreams when we're done with them.

[Android WebView] Close InputStreams when we're done with them.

When the native side of a Java Input Stream is destroyed,
invoke the Java side close() method.

Android only, android bots green
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174967

[benm (inactive), 2013-01-03 14:56:16]

ptal

[mkosiba (inactive), 2013-01-03 15:08:31]

LGTM

Was that a strict mode error or something?

[benm (inactive), 2013-01-03 15:38:00]

On 2013/01/03 15:08:31, Martin Kosiba wrote:
> LGTM
> 
> Was that a strict mode error or something?

Exactly.

[commit-bot: I haz the power, 2013-01-03 15:38:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benm@chromium.org/11748015/1

[commit-bot: I haz the power, 2013-01-03 16:26:40]

Change committed as 174967

[joth, 2013-01-03 19:18:18]

Thanks for fixing this warning.

https://codereview.chromium.org/11748015/diff/1/android_webview/native/input_...
File android_webview/native/input_stream_impl.cc (right):

https://codereview.chromium.org/11748015/diff/1/android_webview/native/input_...
android_webview/native/input_stream_impl.cc:51: DCHECK(!ClearException(env));
the ClearException will be removed in release build, so it's better to just call
CheckException() unconditionally.

[mkosiba (inactive), 2013-01-04 12:31:11]

https://codereview.chromium.org/11748015/diff/1/android_webview/native/input_...
File android_webview/native/input_stream_impl.cc (right):

https://codereview.chromium.org/11748015/diff/1/android_webview/native/input_...
android_webview/native/input_stream_impl.cc:51: DCHECK(!ClearException(env));
uh, actually due to the way the JNI methods are auto-generated the
Java_InputStream_close will CHECK(false) if we get an exception back.

The bug is crbug.com/157880.

[benm (inactive), 2013-01-04 12:55:11]

https://codereview.chromium.org/11748015/diff/1/android_webview/native/input_...
File android_webview/native/input_stream_impl.cc (right):

https://codereview.chromium.org/11748015/diff/1/android_webview/native/input_...
android_webview/native/input_stream_impl.cc:51: DCHECK(!ClearException(env));
I see. So right now in the exception case we'll never hit this; but when that
bug is fixed we would still want to call CheckException() here?

[mkosiba (inactive), 2013-01-04 14:41:01]

https://codereview.chromium.org/11748015/diff/1/android_webview/native/input_...
File android_webview/native/input_stream_impl.cc (right):

https://codereview.chromium.org/11748015/diff/1/android_webview/native/input_...
android_webview/native/input_stream_impl.cc:51: DCHECK(!ClearException(env));
On 2013/01/04 12:55:11, benm wrote:
> I see. So right now in the exception case we'll never hit this; but when that
> bug is fixed we would still want to call CheckException() here?

When the bug is fixed we'll have an unsafe version of the method
(Java_InputStream_unsafe_close ?) which we would have to use instead in order to
have the ClearException code be reachable.
I'd suggest to file a bug to track this.

[benm (inactive), 2013-01-04 16:59:40]

https://codereview.chromium.org/11748015/diff/1/android_webview/native/input_...
File android_webview/native/input_stream_impl.cc (right):

https://codereview.chromium.org/11748015/diff/1/android_webview/native/input_...
android_webview/native/input_stream_impl.cc:51: DCHECK(!ClearException(env));
Gotcha. Follow up in https://codereview.chromium.org/11748032/.