Issue 11748013: Merged r13260, r13266, r13268, r13270, r13274 into 3.15 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11748013: Merged r13260, r13266, r13268, r13270, r13274 into 3.15 branch. (Closed)

Created:
7 years, 11 months ago by Sven Panne

Modified:
7 years, 11 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.15

Visibility:
Public.

More Reviews

Description

Merged r13260, r13266, r13268, r13270, r13274 into 3.15 branch. Refactoring only: Use CheckSSE2OperandIsInt32 instead of copy-n-paste code. Added (dis-)assembler support for movmskps on ia32 and x64. Fixed x64 disassembler for cmpb_al Fixed FloatingPointHelper::CheckSSE2OperandIsInt32. Fix typo in the CheckSSE2OperandIsInt32: use bitwise not instead of integer negation. BUG=v8:2458 R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=13295

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -10 lines)			Patch
M	src/ia32/assembler-ia32.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	2 chunks	+7 lines, -9 lines	0 comments	Download
M	src/ia32/disasm-ia32.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/assembler-x64.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/x64/disasm-x64.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2013/01/03 07:49:12, Sven Panne wrote:

LGTM.

Expand Messages | Collapse Messages