Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 1174743002: Move find_dependencies and related files to internal/ (Closed)

Created:
5 years, 6 months ago by aiolos (Not reviewing)
Modified:
5 years, 6 months ago
Reviewers:
sullivan, dtu, nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, cylee1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move find_dependencies and related files to internal/ BUG=498040 Committed: https://crrev.com/e30560c86624e3adfbac9c9337404f5d1d2e5d77 Cr-Commit-Position: refs/heads/master@{#333662}

Patch Set 1 #

Patch Set 2 : Rebase from the cloud_storage move landing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -568 lines) Patch
M tools/telemetry/find_dependencies View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/internal/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/util/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/util/bootstrap.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/util/find_dependencies.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/internal/util/find_dependencies_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + tools/telemetry/telemetry/internal/util/path_set.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/telemetry/internal/util/path_set_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/telemetry_dependencies_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
D tools/telemetry/telemetry/util/bootstrap.py View 1 chunk +0 lines, -160 lines 0 comments Download
D tools/telemetry/telemetry/util/find_dependencies.py View 1 1 chunk +0 lines, -252 lines 0 comments Download
D tools/telemetry/telemetry/util/find_dependencies_unittest.py View 1 1 chunk +0 lines, -68 lines 0 comments Download
D tools/telemetry/telemetry/util/path_set.py View 1 chunk +0 lines, -44 lines 0 comments Download
D tools/telemetry/telemetry/util/path_set_unittest.py View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
aiolos (Not reviewing)
5 years, 6 months ago (2015-06-09 21:26:13 UTC) #2
achuithb
On 2015/06/09 21:26:13, aiolos wrote: FYI: https://cs.corp.google.com/#chromeos_public/src/third_party/chromiumos-overlay/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild&l=1012 I think this continues to work.
5 years, 6 months ago (2015-06-09 21:31:04 UTC) #3
aiolos (Not reviewing)
On 2015/06/09 21:31:04, achuithb wrote: > On 2015/06/09 21:26:13, aiolos wrote: > > FYI: > ...
5 years, 6 months ago (2015-06-09 21:38:52 UTC) #4
sullivan
lgtm
5 years, 6 months ago (2015-06-09 21:55:25 UTC) #5
nednguyen
On 2015/06/09 21:55:25, sullivan wrote: > lgtm lgtm
5 years, 6 months ago (2015-06-09 22:02:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174743002/1
5 years, 6 months ago (2015-06-09 22:06:30 UTC) #8
dtu
lgtm
5 years, 6 months ago (2015-06-09 22:06:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/69610)
5 years, 6 months ago (2015-06-09 22:38:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174743002/60001
5 years, 6 months ago (2015-06-09 22:55:52 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 6 months ago (2015-06-10 02:35:48 UTC) #17
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 02:36:41 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e30560c86624e3adfbac9c9337404f5d1d2e5d77
Cr-Commit-Position: refs/heads/master@{#333662}

Powered by Google App Engine
This is Rietveld 408576698