Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1174733005: Revert of Gallery: capture escape key in full screen by adding a permission. (Closed)

Created:
5 years, 6 months ago by yawano
Modified:
5 years, 6 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Gallery: capture escape key in full screen by adding a permission. (patchset #2 id:20001 of https://codereview.chromium.org/1149323006/) Reason for revert: All of Gallery Material Redesign will happen in M46. Original issue's description: > Gallery: capture escape key in full screen by adding a permission. > > BUG=497011 > TEST=manually tested; Maximize Gallery and press slideshow button. Confirm that it goes to slideshow mode. After it, press escape key and confirm that it goes back to the original mode. > > Committed: https://crrev.com/7d1560ccb3dfee3c9f1510b035f67261b0b88d8f > Cr-Commit-Position: refs/heads/master@{#333246} TBR=fukino@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497011 Committed: https://crrev.com/77a209184fadf86ea0386608f0c72de4a35b4706 Cr-Commit-Position: refs/heads/master@{#333673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M ui/file_manager/gallery/js/slide_mode.js View 3 chunks +15 lines, -1 line 0 comments Download
M ui/file_manager/gallery/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
yawano
Created Revert of Gallery: capture escape key in full screen by adding a permission.
5 years, 6 months ago (2015-06-10 03:17:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174733005/1
5 years, 6 months ago (2015-06-10 03:18:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 03:18:45 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 03:20:24 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77a209184fadf86ea0386608f0c72de4a35b4706
Cr-Commit-Position: refs/heads/master@{#333673}

Powered by Google App Engine
This is Rietveld 408576698