Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: gpu/command_buffer/service/feature_info_unittest.cc

Issue 1174733003: cc, gpu: Use RGBA when using msaa on systems that don't support BGRA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/feature_info_unittest.cc
diff --git a/gpu/command_buffer/service/feature_info_unittest.cc b/gpu/command_buffer/service/feature_info_unittest.cc
index ecb017798c4868de0d70732b0033d4ce724296b9..fdff1754715e1cb480f141363685d0be4dd56b24 100644
--- a/gpu/command_buffer/service/feature_info_unittest.cc
+++ b/gpu/command_buffer/service/feature_info_unittest.cc
@@ -340,6 +340,7 @@ TEST_P(FeatureInfoTest, InitializeEXT_texture_format_BGRA8888GLES2) {
GL_BGRA_EXT));
EXPECT_FALSE(info_->validators()->render_buffer_format.IsValid(
GL_BGRA8_EXT));
+ EXPECT_FALSE(info_->feature_flags().ext_render_buffer_format_bgra8888);
}
TEST_P(FeatureInfoTest, InitializeEXT_texture_format_BGRA8888GL) {
@@ -350,6 +351,7 @@ TEST_P(FeatureInfoTest, InitializeEXT_texture_format_BGRA8888GL) {
HasSubstr("GL_EXT_read_format_bgra"));
EXPECT_THAT(info_->extensions(),
HasSubstr("GL_CHROMIUM_renderbuffer_format_BGRA8888"));
+ EXPECT_TRUE(info_->feature_flags().ext_render_buffer_format_bgra8888);
EXPECT_TRUE(info_->validators()->texture_format.IsValid(
GL_BGRA_EXT));
EXPECT_TRUE(info_->validators()->texture_internal_format.IsValid(
@@ -370,6 +372,7 @@ TEST_P(FeatureInfoTest, InitializeEXT_texture_format_BGRA8888Apple) {
GL_BGRA_EXT));
EXPECT_FALSE(info_->validators()->render_buffer_format.IsValid(
GL_BGRA8_EXT));
+ EXPECT_FALSE(info_->feature_flags().ext_render_buffer_format_bgra8888);
}
TEST_P(FeatureInfoTest, InitializeEXT_read_format_bgra) {
@@ -384,6 +387,7 @@ TEST_P(FeatureInfoTest, InitializeEXT_read_format_bgra) {
GL_BGRA_EXT));
EXPECT_FALSE(info_->validators()->render_buffer_format.IsValid(
GL_BGRA8_EXT));
+ EXPECT_FALSE(info_->feature_flags().ext_render_buffer_format_bgra8888);
}
TEST_P(FeatureInfoTest, InitializeEXT_sRGB) {
@@ -592,6 +596,7 @@ TEST_P(FeatureInfoTest, InitializeWithANGLE_BGRA8) {
EXPECT_TRUE(info_->gl_version_info().is_angle);
EXPECT_THAT(info_->extensions(),
HasSubstr("GL_CHROMIUM_renderbuffer_format_BGRA8888"));
+ EXPECT_TRUE(info_->feature_flags().ext_render_buffer_format_bgra8888);
EXPECT_TRUE(info_->validators()->render_buffer_format.IsValid(GL_BGRA8_EXT));
}
@@ -599,6 +604,7 @@ TEST_P(FeatureInfoTest, InitializeWithANGLE_BGRA8) {
TEST_P(FeatureInfoTest,
InitializeGLES2_no_CHROMIUM_renderbuffer_format_BGRA8888) {
SetupInitExpectationsWithGLVersion("", "", "OpenGL ES 2.0");
+ EXPECT_FALSE(info_->feature_flags().ext_render_buffer_format_bgra8888);
EXPECT_THAT(info_->extensions(),
Not(HasSubstr("GL_CHROMIUM_renderbuffer_format_BGRA8888")));
}
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698